Skip to content

Commit

Permalink
More terminology of Review -> Discussion
Browse files Browse the repository at this point in the history
  • Loading branch information
TheMadBug committed Sep 13, 2023
1 parent ebdbfb9 commit eb01a49
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
<div class="container">
<h4>Step 2 of 2</h4>

<div data-toggle="ajax-collapse" href="{% url 'review_detail' review.pk %}?show_outcome=false" title="Review Summary"></div>
<div data-toggle="ajax-collapse" href="{% url 'review_detail' review.pk %}?show_outcome=false" title="Discussion Summary"></div>

<form method="post" id="resolve-form">
<div class="card mt-4">
Expand Down
10 changes: 5 additions & 5 deletions review/templates/review/review_detail.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
{% load js_tags %}
{% load user_tags %}
<div class="card">
<div class="card-header">Review {% admin_link review %}</div>
<div class="card-header">Discussion {% admin_link review %}</div>
<div class="card-body">
{% if show_source_object %}
{% labelled label="Review Of" %}{% preview review.reviewing.source_object %}{% endlabelled %}
{% labelled label="Discussion Of" %}{% preview review.reviewing.source_object %}{% endlabelled %}
{% endif %}
{% labelled label="On The Topic Of" %}{{ review.topic.name }}{% endlabelled %}
{% labelled label="On The Date" %}{{ review.review_date }}{% endlabelled %}

{% labelled label="Methods of Review" %}
{% labelled label="Methods of Discussion" %}
{% for item in review.review_method %}
{% if not forloop.first %}<br/>{% endif %}
{{ item }}
Expand All @@ -23,13 +23,13 @@
{{ item }}
{% endfor %}
{% endlabelled %}
{% labelled label="Reviewing Labs" %}
{% labelled label="Discussing Labs" %}
{% for lab in review.reviewing_labs.all %}
{% if not forloop.first %}<br/>{% endif %}
{{ lab }}
{% endfor %}
{% endlabelled %}
{% labelled label="Review Last Edited By" %}
{% labelled label="Discussion Last Edited By" %}
{% user review.user show_group=True size="tiny" %} @ {% timestamp review.modified %}
{% endlabelled %}
{% labelled label="Details" %}
Expand Down
2 changes: 1 addition & 1 deletion review/views/review_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def _handle_review(request, review: Review, reviewing: Optional[ReviewableModelM
discussion_form = ReviewForm(review=review, data=request.POST)
if discussion_form.is_valid():
discussion_form.save()
messages.add_message(request, level=messages.SUCCESS, message="Review saved successfully")
messages.add_message(request, level=messages.SUCCESS, message="Discussion saved successfully")

return redirect(discussion_form.review.next_step_url())
else:
Expand Down

0 comments on commit eb01a49

Please sign in to comment.