Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default texture sampling to repeat #701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlueCube3310
Copy link

Changes the texture samplers' repeat properties to repeat by default to make them function the same way they did in previous versions. This fixes the seams that appear when using most processing nodes:

1.3 1.4a 1.4 PR
1_3 1_4 1_4PR

@RodZill4
Copy link
Owner

Hi! Can you please provide the test case? there's still a diffrerence between the 1.3 and 1.4 screenshots and I'd also like to understand this (plus see if there are more required changes for this problem).

@BlueCube3310
Copy link
Author

BlueCube3310 commented Aug 18, 2024

Hi! Here's a very simple test case: repeat_test.zip

The file consists of a checkerboard node connected to HBAO. The output looks like this on different versions (most noticeable with a plane preview mesh):

1.4 alpha:
test

1.3:
test2

@BlueCube3310
Copy link
Author

This can also be seen on many existing materials, such as https://www.materialmaker.org/material?id=998

A noticeable line appears in 1.4 alpha:

1.3:
k3

1.4:
k4

This may also fix #722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants