Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] Compiler Warning tracking issue #47143

Closed
Li-fAngyU opened this issue Oct 19, 2022 · 2 comments
Closed

[CodeStyle] Compiler Warning tracking issue #47143

Li-fAngyU opened this issue Oct 19, 2022 · 2 comments
Assignees
Labels
PFCC Paddle Framework Contributor Club,https://github.com/PaddlePaddle/community/tree/master/pfcc status/close 已关闭 type/new-feature 确认的新需求

Comments

@Li-fAngyU
Copy link
Contributor

Li-fAngyU commented Oct 19, 2022

项目说明

用于跟踪 Call-for-Contributions: 编译 warning 消除计划 并记录该计划下各个子任务的计划和进度。

项目初始状态

目前 Paddle 在 Linux, Mac, Windows 上存在许多 warning,其中大部分是有第三方库引入。去除掉第三方库的影响,在 Linux, Mac, Windows 上分别存在 40, 743, 8 条 warning 记录。

  • 推进方案:对现有的 warning 进行分类修复,然后修复隐藏的 warning, 修复完一类 warning 后将该类 warning 改为 error 避免 warning 重复出现。

Warning 消除阶段性目标

1. 明面Warning

1.1 Linux 明面 Warning(进展 5/6)

序号 Warning 个数 存量修复 增量拦截 作者
1 ✅ [-Wsign-compare] (2022/10/22) 25 #46644 (25) #47252 (11) #47163 Li-fAngyU
2 ✅ [-Wunused-local-typedefs] (2022/11/1) 4 #47513 (4) #47513 GreatV
3 ✅[-Wunused-variable] (2022/11/3) 4 #47558 (4) #47706 #47558 #47706 GreatV
4 ✅[-Wterminate] (2023/3/31) 9 #52307 #52564 @Galaxy1458
5 ✅[-Wmaybe-uninitialized] (2023/3/9) 3 #51336 (3) #51336 @GreatV
6 ✅ [-Wunknown-pragmas] (2023/3/6) 2 #51203 (2) #51203 @GreatV

更新:以2023/02/13某成功PR的流水线 PR-CI-Build 为例。

1.2 Mac 明面 Warning(进展 8/10)

序号 Warning 个数 存量修复 增量拦截 作者
1 ✅ [-Winconsistent-missing-override](2022/10/22) 743 #47264 (743) #47264 GreatV
2 ✅ [-Wformat] (2022/10/19) 31 #47137 (31) #47216 GreatV
3 ✅ [-Wbraced-scalar-init] (2022/10/24) 13 #47309 (13) #47309 GreatV
4-6 ✅ [-Wliteral-conversion] [-Wuninitialized] [-Wtautological-constant-out-of-range-compare] (2022/10/26) 3 #47341 (3) #47341 GreatV
7 ✅[-Wpragma-pack] (2022/10/28) 1 #47399 (1) #47399 GreatV
8 ✅ [-Wc++17-extensions](2022/12/14) 4 #49017 (4) #49017 @AndPuQing
9 ✅[-Wexceptions] (2023/3/31) 2 #52307 #52564 @Galaxy1458
10 [-Wreturn-type-c-linkage] 1

更新:以2023/02/13某成功PR的流水线 PR-CI-Mac-Python3 为例。

1.3 Windows 明面 Warning

TBE

2 未打开的 Warning

2.1 Linux 未打开的 Warning

TBE

2.2 macOS 未打开的 Warning

TBE

3 其他成果总结

子任务和完成时间 相关 PR 作者
✅去掉 boost 库引入的 warning (2022/10/29) #47468 GreatV
✅修复 GCC9.4 下的 maybe-uninitialized 编译错误 #51605 #51633 @engineer1109 @jinyouzhi
@paddle-bot
Copy link

paddle-bot bot commented Oct 19, 2022

您好,我们已经收到了您的问题,会安排技术人员尽快解答您的问题,请耐心等待。请您再次检查是否提供了清晰的问题描述、复现代码、环境&版本、报错信息等。同时,您也可以通过查看官网API文档常见问题历史IssueAI社区来寻求解答。祝您生活愉快~

Hi! We've received your issue and please be patient to get responded. We will arrange technicians to answer your questions as soon as possible. Please make sure that you have posted enough message to demo your request. You may also check out the APIFAQGithub Issue and AI community to get the answer.Have a nice day!

@paddle-bot paddle-bot bot added the PFCC Paddle Framework Contributor Club,https://github.com/PaddlePaddle/community/tree/master/pfcc label Oct 19, 2022
@paddle-bot paddle-bot bot added the status/close 已关闭 label Oct 21, 2022
@paddle-bot paddle-bot bot closed this as completed Oct 21, 2022
@paddle-bot paddle-bot bot removed the status/new-issue 新建 label Oct 21, 2022
@luotao1 luotao1 reopened this Oct 21, 2022
@paddle-bot paddle-bot bot added status/reopen 重新打开 and removed status/close 已关闭 labels Oct 21, 2022
@Ligoml Ligoml added type/new-feature 确认的新需求 and removed type/others 其他问题 status/reopen 重新打开 labels Nov 4, 2022
@luotao1
Copy link
Contributor

luotao1 commented May 10, 2023

编译warning消除(明面)已全部完成!

欢迎继续参与 快乐开源的其他任务

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PFCC Paddle Framework Contributor Club,https://github.com/PaddlePaddle/community/tree/master/pfcc status/close 已关闭 type/new-feature 确认的新需求
Projects
Development

No branches or pull requests

5 participants