-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle] fix pragma-pack warning on macos #47399
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
为什么 |
看了一下都是 eigen3 引入的,一个日志里有单独一行[-Wunknown-warning-option],另一个没有。很奇怪。
|
怀疑是日志没有及时写入,导致多出来的。都是
|
这个warning在apple clang 10中出现,在apple clang 14中就没有了,应该是能识别到 ➜ clang --version
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: arm64-apple-darwin22.1.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin ➜ cat ./0.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
26 [-Wnon-c-typedef-for-linkage]
25 [-Wdeprecated-declarations]
7 [-Wdangling-gsl]
4 [-Wc++17-extensions]
4 [-Walign-mismatch]
2 [-Wexceptions]
1 [-Wreturn-type-c-linkage]
1 [-Wpragma-pack] ➜ cat ./1.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
26 [-Wnon-c-typedef-for-linkage]
25 [-Wdeprecated-declarations]
7 [-Wdangling-gsl]
4 [-Wc++17-extensions]
2 [-Wexceptions]
1 [-Wunused-value]
1 [-Wreturn-type-c-linkage] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. LGTM
PR types
Others
PR changes
Others
Describe
Fix pragma-pack warning on macOS.