Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] fix braced-scalar-init warnings on macos #47309

Merged
merged 1 commit into from
Oct 25, 2022
Merged

[CodeStyle] fix braced-scalar-init warnings on macos #47309

merged 1 commit into from
Oct 25, 2022

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Oct 24, 2022

PR types

Others

PR changes

Others

Describe

fix braced-scalar-init warnings and add -Werror for braced-scalar-init warning on macos

cat ./before.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr

  26 [-Wnon-c-typedef-for-linkage]
  23 [-Wdeprecated-declarations]
  13 [-Wbraced-scalar-init]
   7 [-Wdangling-gsl]
   4 [-Wc++17-extensions]
   4 [-Walign-mismatch]
   2 [-Wexceptions]
   1 [-Wuninitialized]
   1 [-Wtautological-constant-out-of-range-compare]
   1 [-Wreturn-type-c-linkage]
   1 [-Wpragma-pack]
   1 [-Wliteral-conversion]
cat ./after.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
  26 [-Wnon-c-typedef-for-linkage]
  23 [-Wdeprecated-declarations]
   7 [-Wdangling-gsl]
   4 [-Wc++17-extensions]
   4 [-Walign-mismatch]
   2 [-Wexceptions]
   1 [-Wuninitialized]
   1 [-Wtautological-constant-out-of-range-compare]
   1 [-Wreturn-type-c-linkage]
   1 [-Wpragma-pack]
   1 [-Wliteral-conversion]

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Oct 24, 2022
@GreatV
Copy link
Contributor Author

GreatV commented Oct 24, 2022

@luotao1 @zhiqiu

@luotao1 luotao1 self-assigned this Oct 25, 2022
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit d869056 into PaddlePaddle:develop Oct 25, 2022
@GreatV GreatV deleted the fix_macos_warning branch October 25, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants