[Wsign-compare] Close Wno-error=sign_compare

[Li-fAngyU]

PR types

Others

PR changes

Others

Describe

Close Wno-error=sign_compare

• Compiler Warning tracking issue: [CodeStyle] Compiler Warning tracking issue #47143

[paddle-bot]

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

[luotao1]

LGTM

[luotao1]

我下载了这个PR流水线的PR-CI-Coverage和PR-CI-Build。Coverage的编译会多一个deprecated-declaration的warning，可以考虑后续也去掉。

$ grep warning: coverage.log |grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
  21 [-Wdeprecated-declarations]
   5 [-Wterminate]
   4 [-Wunused-variable]
   4 [-Wunused-local-typedefs]
   2 [-Wunknown-pragmas]
$ grep warning: build.log |grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
   6 [-Wterminate]
   4 [-Wunused-variable]
   4 [-Wunused-local-typedefs]
   2 [-Wunknown-pragmas]

[luotao1]

后续可以在PR描述里都加上tracking issue

[Li-fAngyU]

fluid/distributed 下的CMakeLists里的Wno-error=sign-compare没有去除掉。
去除掉的话会触发第三方库的sign-compare error，报错信息

[luotao1]

报错信息：

/workspace/Paddle/paddle/fluid/distributed/test/brpc_utils_test.cc:119:3:   required from here
2022-10-19 16:44:33 /workspace/Paddle/build/third_party/install/gtest/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
2022-10-19 16:44:33    if (lhs == rhs) {

Paddle/paddle/fluid/distributed/test/brpc_utils_test.cc

Line 119 in d6208aa

EXPECT_EQ(slr->rows().size(), 564);

改成 EXPECT_EQ(slr->rows().size(), 564UL); 就不会有这个warning了，可以尝试去掉fluid/distributed 下的CMakeLists里的Wno-error=sign-compare

@Li-fAngyU

[luotao1]

搜了下还有两处 https://github.com/PaddlePaddle/Paddle/search?q=sign-compare

[Li-fAngyU]

好的我修改一下

[Li-fAngyU]

我下载了这个PR流水线的PR-CI-Coverage和PR-CI-Build。Coverage的编译会多一个deprecated-declaration的warning，可以考虑后续也去掉。

$ grep warning: coverage.log |grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
  21 [-Wdeprecated-declarations]
   5 [-Wterminate]
   4 [-Wunused-variable]
   4 [-Wunused-local-typedefs]
   2 [-Wunknown-pragmas]
$ grep warning: build.log |grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
   6 [-Wterminate]
   4 [-Wunused-variable]
   4 [-Wunused-local-typedefs]
   2 [-Wunknown-pragmas]

好的