Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding checkpoint and config version #28

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Adding checkpoint and config version #28

merged 2 commits into from
Nov 5, 2024
+72 −1

Conversation

SamuelLarkin
Copy link
Collaborator

@SamuelLarkin SamuelLarkin commented Oct 25, 2024 •
edited
Loading

PR Goal?

Add a version number in a saved model's checkpoint and a version to EveryVoice's config files.

Fixes?

EveryVoiceTTS/EveryVoice#559

Feedback sought?

Merge approval

Priority?

high

Tests added?

yes

How to test? 

python -m unittest \
  everyvoice.tests.test_model.TestLoadingConfig \
  everyvoice.tests.test_model.TestLoadingModel \
  everyvoice.tests.test_cli

Confidence?

good

Version change?

yes for the schemas

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#92
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#38
#28

@SamuelLarkin SamuelLarkin mentioned this pull request Oct 25, 2024
Merged
@SamuelLarkin SamuelLarkin changed the title [WIP] Dev.sl/559 version [WIP] Adding checkpoint and config version Oct 25, 2024
This was referenced Oct 30, 2024
Merged
Merged
@SamuelLarkin SamuelLarkin changed the title [WIP] Adding checkpoint and config version Adding checkpoint and config version Oct 30, 2024
@joanise
Copy link
Member

joanise commented Oct 30, 2024

I'd like to test this code like I did for fs2 and hfgl. Can you give me a command to run to generate a DFA model, and one to use it?

joanise
joanise approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your patience with all the change requests!

@SamuelLarkin SamuelLarkin merged commit 132c55e into main Nov 5, 2024
2 checks passed
@SamuelLarkin SamuelLarkin deleted the dev.sl/559_version branch November 5, 2024 22:17
@SamuelLarkin SamuelLarkin mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanise joanise joanise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamuelLarkin @joanise