Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning information to all model files #559

Closed
joanise opened this issue Sep 23, 2024 · 2 comments
Closed

Add versioning information to all model files #559

joanise opened this issue Sep 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@joanise
Copy link
Member

joanise commented Sep 23, 2024

Description & Motivation

Vocoder Checkpoints, Feature Prediction checkpoints, etc, need to have versioning information, for two purposes:

  • simplify error messages when the wrong type of model gets loaded
  • recognize that a file is in the format of an older version, and support converting it on the fly if possible or giving good error messages if not.

Pitch

Just like .readalong files now have file format version numbers, we really need this for EV models too.

@joanise joanise added the enhancement New feature or request label Sep 23, 2024
@joanise
Copy link
Member Author

joanise commented Sep 23, 2024

And let's make these fields Optional so that we don't invalidate our existing checkpoints: let them default to the first version number if not found, but let's henceforth generate them every time we create model files & checkpoints & config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants