Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding checkpoint and config version #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding checkpoint and config version #38

wants to merge 3 commits into from

Conversation

SamuelLarkin
Copy link
Collaborator

@SamuelLarkin SamuelLarkin commented Oct 25, 2024 •
edited
Loading

PR Goal?

Add a version number in a saved model's checkpoint and a version to EveryVoice's config files.

Fixes?

EveryVoiceTTS/EveryVoice#559

Feedback sought?

Merge approval

Priority?

high

Tests added?

yes

How to test? 

python -m unittest \
  everyvoice.tests.test_model.TestLoadingConfig \
  everyvoice.tests.test_model.TestLoadingModel \
  everyvoice.tests.test_cli

Confidence?

good

Version change?

yes for the schemas

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#92
#38
EveryVoiceTTS/DeepForcedAligner#28

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 25, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  hfgl/config/__init__.py  1% smaller
  hfgl/model.py  0% smaller
  hfgl/utils.py  0% smaller

@SamuelLarkin SamuelLarkin mentioned this pull request Oct 25, 2024
Open
@SamuelLarkin SamuelLarkin changed the title [WIP] Dev.sl/559 version [WIP] Adding checkpoint and config version Oct 25, 2024
This was referenced Oct 30, 2024
Open
Open
@SamuelLarkin SamuelLarkin changed the title [WIP] Adding checkpoint and config version Adding checkpoint and config version Oct 30, 2024
joanise
joanise reviewed Oct 30, 2024
View reviewed changes
hfgl/model.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanise joanise joanise left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamuelLarkin @joanise