-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate MeshKernelPy >=3.0.0 #574
Merged
priscavdsluis
merged 79 commits into
main
from
569-bumping-meshkernel-version-to-latest-v300
Nov 16, 2023
Merged
Integrate MeshKernelPy >=3.0.0 #574
priscavdsluis
merged 79 commits into
main
from
569-bumping-meshkernel-version-to-latest-v300
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…://github.com/Deltares/HYDROLIB-core into 569-bumping-meshkernel-version-to-latest-v300
This was referenced Nov 2, 2023
…://github.com/Deltares/HYDROLIB-core into 569-bumping-meshkernel-version-to-latest-v300
hydrolib/core/dflowfm/net/reader.py
Outdated
|
||
# bathymetry | ||
node_z = self._read_nc_attribute(ds["mesh2d_node_z"]) | ||
mesh2d.mesh2d_node_z = node_z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should face_z also be set?
priscavdsluis
approved these changes
Nov 16, 2023
priscavdsluis
changed the title
updated meshkernel API calls
Integrate MeshKernelPy >=3.0.0
Nov 16, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
priscavdsluis
deleted the
569-bumping-meshkernel-version-to-latest-v300
branch
November 16, 2023 13:07
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meshkernel 3.0.0 was released on the 27th of October. This is great news since it contains many new and improved features. However, there are also some fundamental API changes. I tried my best to process them in this PR. The testbank is extended a bit and all green, which already took quite some effort. Mainly since the current code also did not work with meshkernel 2.1.0 but only 2.0.2 or maybe older. With the current changes, also the hydromt_delft3dfm testbank is green when using this hydrolib-core branch and some minor edits in the hydromt_delft3dfm code: Deltares/hydromt_delft3dfm#109
In short:
Mesh2D
class was trimmed down to avoid out of sync instances (mesh2d.mesh2d_node_x
now comes frommesh2d.meshkernel.mesh2d_get().node_x
)Follow-up issues (also mentioned in TODO comments in PR code):
contacts
in Network instance created from netfile #575UgridReader
andUgridWriter
with xugrid #577face_z
andnode_z
array sizes with meshkernel #579