Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping meshkernel version to latest (v3.0.0) #569

Closed
ahmad-el-sayed opened this issue Oct 19, 2023 · 1 comment · Fixed by #574
Closed

Bumping meshkernel version to latest (v3.0.0) #569

ahmad-el-sayed opened this issue Oct 19, 2023 · 1 comment · Fixed by #574

Comments

@ahmad-el-sayed
Copy link

What is the need for this task.
Currently, HYDROLIB-core uses meshkernelpy 2.0.2, as configured here. A minor version 2.1.0 was released last July and version 3.0.0 is planned next week.

What is the task?
Is there interest in bumping the version to 3.0.0?

Benefits:

  • improvements in performance
  • new features
  • bug fixes

These has been API changes. The MeshkernelPy team can gladly assist.

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 23, 2023

It is necessary to include the API changes from meshkernel 3.0.0 and use that as a minimal required version.

Fundamentally, these things should be updated:

  • hydrolib-core requires meshkernel^2.0.0 (so <3.0.0), update to meshkernel^3.0.0 after updates
  • hydrolib-core calls mk.DeleteMeshOption.ALL_FACE_CIRCUMCENTERS upon hydrolib-core import, update to new meshkernel.DeleteMeshOption.INSIDE_NOT_INTERSECTED.
  • hydrolib-core calls mk.MeshKernel(is_geographic=is_geographic) upon mdu = hcdfm.FMModel()
  • update DeleteMeshOption everywhere
  • update to is_geographic to projection everywhere (including enum instead of bool)
  • delete poetry.lock necessary? (wait until meshkernel 3.0.0 is released)

However, there is more to it I cannot completely oversee yet:

  • HYDROLIB-core currently runs the github testbank with meshkernel 2.0.2 due to poetry.lock. I noticed in a local test (meshkernel 2.1.0) that the deprecated meshkernel.Mesh2dFactory() is called in tests/dflowfm/test_net.py.
  • there are many functions that use meshkernelpy API's that were changed. A brief overview is available in this issue and it's comments: update meshkernel api calls after new release dfm_tools#563
  • hydrolib testbank is now green, but hydromt_delft3dfm uses hydrolib-core for mesh generation and the testbank fails: 105 update meshkernel api calls to version 300 hydromt_delft3dfm#109 >> probably some things were damaged in this PR

@veenstrajelmer veenstrajelmer linked a pull request Oct 23, 2023 that will close this issue
6 tasks
priscavdsluis added a commit that referenced this issue Nov 16, 2023
priscavdsluis added a commit that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants