Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate MeshKernelPy >=3.0.0 #574

Merged
merged 79 commits into from
Nov 16, 2023
Merged

Integrate MeshKernelPy >=3.0.0 #574

merged 79 commits into from
Nov 16, 2023

Commits on Oct 23, 2023

  1. updated minimal meshkernel requirement in pyproject.toml

    @veenstrajelmer
    veenstrajelmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5f2897b View commit details
    Browse the repository at this point in the history

  2. update fundamental changes to make import possible again

    @veenstrajelmer
    veenstrajelmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    736765a View commit details
    Browse the repository at this point in the history

  3. avoid pytest crash by preventing import of deprecated DeleteMeshOptions

    @veenstrajelmer
    veenstrajelmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    71c2719 View commit details
    Browse the repository at this point in the history

  4. update deprecated mk.Mesh2dFactory to newer alternative

    @veenstrajelmer
    veenstrajelmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    666e68e View commit details
    Browse the repository at this point in the history

  5. added comments

    @veenstrajelmer
    veenstrajelmer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    4a2846d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. fixed several testcases

    @veenstrajelmer
    veenstrajelmer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5edc650 View commit details
    Browse the repository at this point in the history

  2. fixed several testcases

    @veenstrajelmer
    veenstrajelmer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d971d2f View commit details
    Browse the repository at this point in the history

  3. updated lockfile

    @veenstrajelmer
    veenstrajelmer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    91cc145 View commit details
    Browse the repository at this point in the history

  4. trigger github testbank

    @veenstrajelmer
    veenstrajelmer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    99b2f5a View commit details
    Browse the repository at this point in the history

  5. trigger github testbank

    @veenstrajelmer
    veenstrajelmer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b0fe0ac View commit details
    Browse the repository at this point in the history

  6. deleted lockfile

    @veenstrajelmer
    veenstrajelmer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    97a19cb View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. changing some defaults to backwards compatible and adding comments

    @veenstrajelmer
    veenstrajelmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    e89d998 View commit details
    Browse the repository at this point in the history

  2. added comments

    @veenstrajelmer
    veenstrajelmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    8ddbf54 View commit details
    Browse the repository at this point in the history

  3. fixed testcases but might fail other things

    @veenstrajelmer
    veenstrajelmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    2f4f8f2 View commit details
    Browse the repository at this point in the history

  4. cleanup and add commented plots

    @veenstrajelmer
    veenstrajelmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ed3fa17 View commit details
    Browse the repository at this point in the history

  5. commented conflicting code

    @veenstrajelmer
    veenstrajelmer committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    bf51790 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. removed much of the nesting, 7 cased fail but no empty initial networ… 

    …k anymore
    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d8c91a2 View commit details
    Browse the repository at this point in the history

  2. minimal changes, but mesh2d_set in functions instead of outside

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f36c2dd View commit details
    Browse the repository at this point in the history

  3. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f484b9f View commit details
    Browse the repository at this point in the history

  4. uncomment face_nodes

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    ba7ea0c View commit details
    Browse the repository at this point in the history

  5. uncomment face_nodes

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a631aff View commit details
    Browse the repository at this point in the history

  6. uncomment face_nodes

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    43932e6 View commit details
    Browse the repository at this point in the history

  7. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d0191cd View commit details
    Browse the repository at this point in the history

  8. net reading consistent and extra test

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b37b3d9 View commit details
    Browse the repository at this point in the history

  9. Merge branch '569-bumping-meshkernel-version-to-latest-v300' of https… 

    …://github.com/Deltares/HYDROLIB-core into 569-bumping-meshkernel-version-to-latest-v300
    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2dfabee View commit details
    Browse the repository at this point in the history

  10. add comment

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e5aefb7 View commit details
    Browse the repository at this point in the history

  11. set types for mesh2d more strict, hopefully unix test also passes

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f77b695 View commit details
    Browse the repository at this point in the history

  12. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    449ff35 View commit details
    Browse the repository at this point in the history

  13. fixed two extra testcases that were ignored before

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    564f301 View commit details
    Browse the repository at this point in the history

  14. also run plot tests on github

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b5e0041 View commit details
    Browse the repository at this point in the history

  15. Merge branch '569-bumping-meshkernel-version-to-latest-v300' of https… 

    …://github.com/Deltares/HYDROLIB-core into 569-bumping-meshkernel-version-to-latest-v300
    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e607ba7 View commit details
    Browse the repository at this point in the history

  16. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6d46edf View commit details
    Browse the repository at this point in the history

  17. fixed 1d2d reading

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2f0eec2 View commit details
    Browse the repository at this point in the history

  18. Merge branch '569-bumping-meshkernel-version-to-latest-v300' of https… 

    …://github.com/Deltares/HYDROLIB-core into 569-bumping-meshkernel-version-to-latest-v300
    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3f81bbb View commit details
    Browse the repository at this point in the history

  19. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    0358325 View commit details
    Browse the repository at this point in the history

  20. minor changes

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    35f6c52 View commit details
    Browse the repository at this point in the history

  21. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7b11714 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. more testing and less usage of copied properties

    @veenstrajelmer
    veenstrajelmer committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2d58e8d View commit details
    Browse the repository at this point in the history

  2. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5770147 View commit details
    Browse the repository at this point in the history

  3. removed many properties and made _process empty, 1 failing testcase

    @veenstrajelmer
    veenstrajelmer committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d106bc0 View commit details
    Browse the repository at this point in the history

  4. test reading 1d2dlinks

    @veenstrajelmer
    veenstrajelmer committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a08cd43 View commit details
    Browse the repository at this point in the history

  5. cleanup and additional testing

    @veenstrajelmer
    veenstrajelmer committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0e43351 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. reintroduced mesh2d_node_x and others as properties, fixes two testcases

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2b0c00e View commit details
    Browse the repository at this point in the history

  2. removed mesh2d _process function

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f6ebfa5 View commit details
    Browse the repository at this point in the history

  3. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    40d7555 View commit details
    Browse the repository at this point in the history

  4. removed last is_geographic

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d0bf2b3 View commit details
    Browse the repository at this point in the history

  5. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    dd189b3 View commit details
    Browse the repository at this point in the history

  6. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1302b75 View commit details
    Browse the repository at this point in the history

  7. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    cccfc1a View commit details
    Browse the repository at this point in the history

  8. expanded testcase

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9e82b39 View commit details
    Browse the repository at this point in the history

  9. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b780b80 View commit details
    Browse the repository at this point in the history

  10. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    937e25d View commit details
    Browse the repository at this point in the history

  11. all plotting on github also

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6ab861d View commit details
    Browse the repository at this point in the history

  12. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c5c2d03 View commit details
    Browse the repository at this point in the history

  13. removed outdated comments to minimize diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2744f2b View commit details
    Browse the repository at this point in the history

  14. solved conflicts

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    395fa18 View commit details
    Browse the repository at this point in the history

  15. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9d12312 View commit details
    Browse the repository at this point in the history

  16. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    31a0adb View commit details
    Browse the repository at this point in the history

  17. minimized diff

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    436377c View commit details
    Browse the repository at this point in the history

  18. removed plotting functions from test script, deprecated

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    bd6c4ec View commit details
    Browse the repository at this point in the history

  19. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8d898a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. accept ax as input for network.plot()

    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0fe4ec5 View commit details
    Browse the repository at this point in the history

  2. re-introduced is_geograpic to avoid hydrolib api change

    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    184cd94 View commit details
    Browse the repository at this point in the history

  3. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7361b51 View commit details
    Browse the repository at this point in the history

  4. added issue numbers to TODO comments

    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b134658 View commit details
    Browse the repository at this point in the history

  5. Merge branch '569-bumping-meshkernel-version-to-latest-v300' of https… 

    …://github.com/Deltares/HYDROLIB-core into 569-bumping-meshkernel-version-to-latest-v300
    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6edd272 View commit details
    Browse the repository at this point in the history

  6. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    025fb3a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into 569-bumping-meshkernel-version-to-latest-v300

    @veenstrajelmer
    veenstrajelmer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b1861d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Merge branch 'main' into 569-bumping-meshkernel-version-to-latest-v300

    @priscavdsluis
    priscavdsluis authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a9ceea8 View commit details
    Browse the repository at this point in the history

  2. #569: Temporarily pin type-enforced on 0.0.16 because of a bug in lat… 

    …er versions
    @priscavdsluis
    priscavdsluis committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a7de166 View commit details
    Browse the repository at this point in the history

  3. #569: Add type hints and docs

    @priscavdsluis
    priscavdsluis committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1265647 View commit details
    Browse the repository at this point in the history

  4. #569: Clean up

    @priscavdsluis
    priscavdsluis committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    251ee55 View commit details
    Browse the repository at this point in the history

  5. autoformat: isort & black

    @priscavdsluis
    priscavdsluis committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a050b10 View commit details
    Browse the repository at this point in the history

  6. added face_z and properly used mapping for attributes

    @veenstrajelmer
    veenstrajelmer committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    06de9b8 View commit details
    Browse the repository at this point in the history

  7. autoformat: isort & black

    @veenstrajelmer
    veenstrajelmer committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f72b77b View commit details
    Browse the repository at this point in the history

  8. cleanup

    @veenstrajelmer
    veenstrajelmer committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    715aca7 View commit details
    Browse the repository at this point in the history

  9. fixed conflict

    @veenstrajelmer
    veenstrajelmer committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    deaec8c View commit details
    Browse the repository at this point in the history

  10. #569: Add docs and remove code smells

    @priscavdsluis
    priscavdsluis committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    22037a0 View commit details
    Browse the repository at this point in the history

  11. autoformat: isort & black

    @priscavdsluis
    priscavdsluis committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    9d1d38f View commit details
    Browse the repository at this point in the history