Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6855] Avoid updating share during version creation #10917

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jan 13, 2025

Purpose

Avoid updating share during version creation

Changes

  • Update VersionedGuidMixin to require subclasses implementing update_search() with kwargs skip_share
  • Update Preprint's update_search() to handle the new kwarg
  • Refactored preprint update API and subject update API to handle the new kwarg
  • Set skip_share=True when creating a new version
  • Only call update_search() with the new kwarg if self is subclasses of VersionedGuidMixin

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6855

@cslzchen cslzchen force-pushed the feature/fix-update-search-for-subjects branch from 7e4e125 to 4b1bc6a Compare January 14, 2025 03:09
@cslzchen cslzchen marked this pull request as ready for review January 14, 2025 19:05
@cslzchen cslzchen requested a review from brianjgeiger January 14, 2025 19:10
@cslzchen cslzchen force-pushed the feature/fix-update-search-for-subjects branch from 72f6b00 to b80855b Compare January 14, 2025 20:31
@cslzchen cslzchen merged commit 2d8c54e into CenterForOpenScience:feature/preprints-doi-versioning Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants