Fix update_search for subclasses of VersionedGuidMixin

osf/models/base.py

@@ -602,6 +602,10 @@ def get_semantic_iri(self):
             raise ValueError(f'no osfid for {self} (cannot build semantic iri)')
         return osfid_iri(_osfid)
 
+    def update_search(self, skip_share=False):
+        """Subclasses must implement `update_search()` with kwarg `skip_share=False`."""
+        raise NotImplementedError()
+
 @receiver(post_save)
 def ensure_guid(sender, instance, **kwargs):
     """Generate guid if it doesn't exist for subclasses of GuidMixin except for subclasses of VersionedGuidMixin

osf/models/mixins.py

@@ -1135,7 +1135,10 @@ def set_subjects(self, new_subjects, auth, add_log=True, skip_share=False):
 
         self.save()
         if hasattr(self, 'update_search'):
-            self.update_search(skip_share=skip_share)
+            from osf.models.base import VersionedGuidMixin
+            if isinstance(self, VersionedGuidMixin):
+                self.update_search(skip_share=skip_share)
+            self.update_search()
 
     def set_subjects_from_relationships(self, subjects_list, auth, add_log=True, skip_share=False):
         """ Helper for setting M2M subjects field from list of flattened subjects received from UI.
@@ -1162,7 +1165,10 @@ def set_subjects_from_relationships(self, subjects_list, auth, add_log=True, ski
 
         self.save()
         if hasattr(self, 'update_search'):
-            self.update_search(skip_share=skip_share)
+            from osf.models.base import VersionedGuidMixin
+            if isinstance(self, VersionedGuidMixin):
+                self.update_search(skip_share=skip_share)
+            self.update_search()
 
     def map_subjects_between_providers(self, old_provider, new_provider, auth=None):
         """