Fix set_subjects

CenterForOpenScience · Jan 14, 2025 · b80855b · b80855b
1 parent 1838633
commit b80855b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/api/subjects/serializers.py b/api/subjects/serializers.py
@@ -15,6 +15,7 @@
 
 
 class UpdateSubjectsMixin:
+
     def update_subjects_method(self, resource, subjects, auth, skip_share=False):
         # Method to update subjects on resource
         raise NotImplementedError()

diff --git a/osf/models/mixins.py b/osf/models/mixins.py
@@ -1138,7 +1138,8 @@ def set_subjects(self, new_subjects, auth, add_log=True, skip_share=False):
             from osf.models.base import VersionedGuidMixin
             if isinstance(self, VersionedGuidMixin):
                 self.update_search(skip_share=skip_share)
-            self.update_search()
+            else:
+                self.update_search()
 
     def set_subjects_from_relationships(self, subjects_list, auth, add_log=True, skip_share=False):
         """ Helper for setting M2M subjects field from list of flattened subjects received from UI.
@@ -1168,7 +1169,8 @@ def set_subjects_from_relationships(self, subjects_list, auth, add_log=True, ski
             from osf.models.base import VersionedGuidMixin
             if isinstance(self, VersionedGuidMixin):
                 self.update_search(skip_share=skip_share)
-            self.update_search()
+            else:
+                self.update_search()
 
     def map_subjects_between_providers(self, old_provider, new_provider, auth=None):
         """