options to the produceSkeletons script to enable V11 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 1, 2019 10:46
…itions as parameters: a way of enabling the usage of V11 HGCAL geometry
…ns as a parameter: a way of enabling the usage of V11 HGCAL geometry (ops for geometry and custom were alrady there)
Merged
|
Hi @franzoni - thank you, this looks very neat! Given the addition of HFNose options (see CMS-HGCAL/reco-ntuples#81 and #86) this seems the best way to go, since otherwise we'd end up with lots of shell scripts that duplicate a lot of lines. With the additional options, the README would have to be updated accordingly so that recommended/available options are clear to everyone. What do you think about the suggestion I made in #86 (comment) regarding the ntupliser config replacement? I would suggest we first merge #86, and then move ahead with this PR, updating the README and shell scripts. This PR would probably have to be rebased then. Do you agree, @franzoni ? |
|
agree, sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a minimal approach towards enabling the usage of the V11 geometry for HGCAL MC.
Taking into account @clelange and @rovere 's comments here, in this PR I add to produceSkeletons_D41_NoSmear_PU_AVE_200_BX_25ns_aged.sh and produceSkeletons_D41_NoSmear_noPU.sh command line options which allow to specify geometry, custom and global tag.
This is a minimal approach which, together with instructions, will address strictly
and can be extended to all produceSkeletons*.sh if desired.
If we want to add specific scripts like: produceSkeletons_D46_NoSmear_PU_AVE_200_BX_25ns.sh
, where the actual values of geometry, custom and global tag are specified, it can be done as well, following the statement:
@pfs @rovere @clelange