Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HF+Nose option #86

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Added HF+Nose option #86

merged 4 commits into from
Nov 7, 2019

Conversation

selvaggi
Copy link
Contributor

Added HF+Nose skeleton.
See CMS-HGCAL/reco-ntuples#81

@clelange
Copy link
Contributor

clelange commented Nov 5, 2019

This looks good to me. The only question I have connected to CMS-HGCAL/reco-ntuples#81 ---and as you state in the updated README---is that one would have to manually change the ntupliser configuration to set the desired algorithm. It would be nice if the shell script did this automatically when running the script (and the other scripts would have to switch back). Maybe something to keep in mind when moving forward with #87 by @franzoni
What do you think?

@selvaggi
Copy link
Contributor Author

selvaggi commented Nov 5, 2019

@clelange yes this is possible, I will set up the correct parameters in the templates for running the nose.

I have another question, is there a particular reason why the main submission script does not give the option to set the number of pile-up anymore? Any interest in adding it back? I think this would be pretty useful as one might now need to regenerate a full set of cfg simply because of swtiching from 200 to 140 PU.

@pfs
Copy link
Contributor

pfs commented Nov 5, 2019 via email

@clelange
Copy link
Contributor

clelange commented Nov 5, 2019

I have another question, is there a particular reason why the main submission script does not give the option to set the number of pile-up anymore? Any interest in adding it back? I think this would be pretty useful as one might now need to regenerate a full set of cfg simply because of swtiching from 200 to 140 PU.

🤔 I don't think this disappeared intentionally... I don't even recall when this happened.

@clelange clelange merged commit 7a69bb2 into CMS-HGCAL:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants