-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for ALL steps to be ran in one submission. #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me, I just have two questions/comments in-line, and will have to test this myself (tomorrow/Wednesday).
Ah, OK, I didn't realise that only the NTUP part is written out. What about adding options to keep (i.e. copy) the intermediate steps as well? We could also address this in a separate PR later. My current use case is actually to only run up to the RECO step, and I'd like to keep both GSD and RECO (the only reason for GSD being that we do not have a re-RECO step at the moment), so the ALL step doesn't address my use case, and I was wondering whether one could introduce a "allInOne" option instead of the ALL data tier, and allow for the data tier a comma-separated list that would determine the output to be stored. For example, Let me know what you prefer. |
Yes, it is a good idea. But I would prefer we merge this first (after you have tested it), and then upgrade to what you suggest later. I have some others small items that I would like to add first. |
closed accidentally! Sorry. |
Trying to re-open. |
thanks @selvaggi |
@franzoni I'm done in terms of code and documentation review, but haven't taken the time to actually take this branch and run a few test jobs. |
This enables the possibility of running the 3 steps together in one single submission by specifying the --datTier ALL option.