Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: remove zephyr,panel-timing compat #79529

Closed
wants to merge 1 commit into from
Closed

dts: remove zephyr,panel-timing compat #79529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion boards/renesas/da1469x_dk_pro/dts/da1469x_dk_pro_lcdc.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
* driver IC.
*/
display-timings {
compatible = "zephyr,panel-timing";
hsync-len = <2>;
hfront-porch = <2>;
hback-porch = <3>;
Expand Down
1 change: 0 additions & 1 deletion boards/shields/rk043fn02h_ct/rk043fn02h_ct.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
width = <480>;
height = <272>;
display-timings {
compatible = "zephyr,panel-timing";
hsync-len = <41>;
hfront-porch = <4>;
hback-porch = <8>;
Expand Down
1 change: 0 additions & 1 deletion boards/shields/rk043fn66hs_ctg/rk043fn66hs_ctg.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
width = <480>;
height = <272>;
display-timings {
compatible = "zephyr,panel-timing";
hsync-len = <4>;
hfront-porch = <8>;
hback-porch = <43>;
Expand Down
1 change: 0 additions & 1 deletion boards/shields/rk055hdmipi4m/rk055hdmipi4m.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
width = <720>;
height = <1280>;
display-timings {
compatible = "zephyr,panel-timing";
hsync-len = <8>;
hfront-porch = <32>;
hback-porch = <32>;
Expand Down
1 change: 0 additions & 1 deletion boards/shields/rk055hdmipi4ma0/rk055hdmipi4ma0.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
width = <720>;
height = <1280>;
display-timings {
compatible = "zephyr,panel-timing";
hsync-len = <6>;
hfront-porch = <12>;
hback-porch = <24>;
Expand Down
1 change: 0 additions & 1 deletion boards/shields/st_b_lcd40_dsi1_mb1166/st_b_lcd40_dsi1_mb1166.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
pixel-format = <PANEL_PIXEL_FORMAT_RGB_888>;
/* orisetech, otm8009a */
display-timings {
compatible = "zephyr,panel-timing";
hsync-active = <0>;
vsync-active = <0>;
de-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/shields/st_b_lcd40_dsi1_mb1166/st_b_lcd40_dsi1_mb1166_a09.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
pixel-format = <PANEL_PIXEL_FORMAT_RGB_888>;
/* frida, nt35510 */
display-timings {
compatible = "zephyr,panel-timing";
hsync-active = <0>;
vsync-active = <0>;
de-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/st/stm32f429i_disc1/stm32f429i_disc1.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@
height = <320>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
display-timings {
compatible = "zephyr,panel-timing";
de-active = <0>;
pixelclk-active = <0>;
hsync-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/st/stm32f746g_disco/stm32f746g_disco.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ zephyr_udc0: &usbotg_fs {
height = <272>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
display-timings {
compatible = "zephyr,panel-timing";
de-active = <0>;
pixelclk-active = <0>;
hsync-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/st/stm32f7508_dk/stm32f7508_dk.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ zephyr_udc0: &usbotg_fs {
height = <272>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
display-timings {
compatible = "zephyr,panel-timing";
de-active = <0>;
pixelclk-active = <0>;
hsync-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/st/stm32h750b_dk/stm32h750b_dk.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
height = <272>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
display-timings {
compatible = "zephyr,panel-timing";
de-active = <1>;
pixelclk-active = <0>;
hsync-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/st/stm32h7b3i_dk/stm32h7b3i_dk.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@
height = <272>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
display-timings {
compatible = "zephyr,panel-timing";
de-active = <0>;
pixelclk-active = <0>;
hsync-active = <0>;
Expand Down
1 change: 0 additions & 1 deletion boards/witte/linum/linum.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ zephyr_udc0: &usbotg_fs {
height = <272>;
pixel-format = <PANEL_PIXEL_FORMAT_RGB_565>;
display-timings {
compatible = "zephyr,panel-timing";
de-active = <1>;
pixelclk-active = <0>;
hsync-active = <0>;
Expand Down
3 changes: 3 additions & 0 deletions dts/bindings/display/lcd-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ properties:
description: |
Initial Pixel format for panel attached to this controller.
See dt-bindings/display/panel.h for a list

child-binding:
include: panel-timing.yaml
40 changes: 18 additions & 22 deletions dts/bindings/display/panel/panel-timing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,24 @@
# Common fields for panel timings
# inherited from Linux panel bindings.

description: |
Common timing settings for display panels. These timings can be added to
a panel under display-timings node. For example:

&lcdif {
display-timings {
compatible = "zephyr,panel-timing";
hsync-len = <8>;
hfront-porch = <32>;
hback-porch = <32>;
vsync-len = <2>;
vfront-porch = <16>;
vback-porch = <14>;
hsync-active = <0>;
vsync-active = <0>;
de-active = <1>;
pixelclk-active = <0>;
clock-frequency = <62346240>;
};
};

compatible: "zephyr,panel-timing"
# Common timing settings for display panels. These timings can be added to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can child bindings not have a description? Not sure why this needs to be commented out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they can, but no documentation would get generated for it AFAIK, so I don't see the point, but it doesn't hurt anything, I guess, so I can put it back if you care enough. But do you know what would be the point?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is no strong reason to do it either way. The only reason I can think of to use the description property would be if we did start generating the documentation in the future. It also follows the pattern we use for other child bindings, where we do add a description property

# a panel under display-timings node. For example:
#
# &lcdif {
# display-timings {
# hsync-len = <8>;
# hfront-porch = <32>;
# hback-porch = <32>;
# vsync-len = <2>;
# vfront-porch = <16>;
# vback-porch = <14>;
# hsync-active = <0>;
# vsync-active = <0>;
# de-active = <1>;
# pixelclk-active = <0>;
# clock-frequency = <62346240>;
# };
# };

properties:
clock-frequency:
Expand Down
Loading