dts: remove zephyr,panel-timing compat #79529
Conversation
Since the panel timing node comes from linux bindings, let's try to remove the zephyr-specific compatible by using a child binding. This would potentially require some other work if another type of child node is needed to be specified in the future. Signed-off-by: Declan Snyder <[email protected]>
| }; | ||
|
|
||
| compatible: "zephyr,panel-timing" | ||
| # Common timing settings for display panels. These timings can be added to |
There was a problem hiding this comment.
Can child bindings not have a description? Not sure why this needs to be commented out.
There was a problem hiding this comment.
they can, but no documentation would get generated for it AFAIK, so I don't see the point, but it doesn't hurt anything, I guess, so I can put it back if you care enough. But do you know what would be the point?
There was a problem hiding this comment.
I guess there is no strong reason to do it either way. The only reason I can think of to use the description property would be if we did start generating the documentation in the future. It also follows the pattern we use for other child bindings, where we do add a description property
|
I actually think I don't want this PR to be merged right now, I'd rather just rework the DT tooling and expand the zephyr binding yaml schema since this is a common problem, but I'll leave this draft open as a reminder |
|
closed in favor of something like #79751 |
Since the panel timing node comes from linux bindings, let's try to remove the zephyr-specific compatible by using a child binding. This would potentially require some other work if another type of child node is needed to be specified in the future.
This compatible was mentioned in #74415 as a supporting example for more zephyr-specific compatibles, hence the motivation of this PR.