Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmv2: Add and use board identifiers for boards with revisions #69568

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

nordicjm
Copy link
Collaborator

No description provided.

@carlescufi carlescufi mentioned this pull request Feb 28, 2024
11 tasks
@nordicjm nordicjm force-pushed the hwmv2-ids branch 2 times, most recently from 722ca3f to 0fb8f81 Compare February 28, 2024 14:03
@nordicjm
Copy link
Collaborator Author

@erwango there is a problem with stm32f411e_disco, it specifies revisions B and D in board.yml but has revision files for B and E

@erwango
Copy link
Member

erwango commented Feb 28, 2024

Question on the change :
Does this mean that there is no default anymore ?

My concern is this one:
We're using a board_foo since long time which has no revision. It's name (board_foo) is spread in multiple yaml files (tests, samples, boards/foo.overlays).
Someone adds a new revision to this board (board_foo@2). Should we then update all references (s/board_foo/board_foo@1) ? Or can we just keep the initial revision as the default and keep using board_foo ?

@nordicjm
Copy link
Collaborator Author

Question on the change : Does this mean that there is no default anymore ?

My concern is this one: We're using a board_foo since long time which has no revision. It's name (board_foo) is spread in multiple yaml files (tests, samples, boards/foo.overlays). Someone adds a new revision to this board (board_foo@2). Should we then update all references (s/board_foo/board_foo@1) ? Or can we just keep the initial revision as the default and keep using board_foo ?

No change is needed, so the change here is just in the identifiers which is for twister, the default revision remains the same and building without a revision will work the same as it did before this change, as well as the same overlays being applied. Changes here just affect twister and tests which addresses an issue with clashing twister paths and allows for easier issue tracking if a board fails to know what the actual revision that is failing is

Adds dedicated yaml files for board that have revisions

Signed-off-by: Jamie McCrae <[email protected]>
Updates boards so that the correct revision/revisions is/are tested

Signed-off-by: Jamie McCrae <[email protected]>
@carlescufi carlescufi merged commit 38df84e into zephyrproject-rtos:collab-hwm Feb 28, 2024
23 checks passed
@nordicjm nordicjm deleted the hwmv2-ids branch July 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants