-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwmv2: tests: drivers: flash: Renamed missed board rename #69597
hwmv2: tests: drivers: flash: Renamed missed board rename #69597
Conversation
Fixes a test which missed the rename of a board Signed-off-by: Jamie McCrae <[email protected]>
Adds a file back that was wrongly deleted in an unrelated commit Signed-off-by: Jamie McCrae <[email protected]>
- stm32f3_disco | ||
- stm32f3_disco@B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is were this unclear to me. Is that required to define a revision in twister if a default is available ?
From your answer here this was not required, but then why doing such change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twister needs to define the revision to use yes because it uses the identifiers from the yaml files, this is to make it clear what revision is being built for. It is users that do not, you can continue building using west
and cmake
without the revision and it will use the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so if one adds a revision to a board, all references to the board in twister should be renamed.... This isn't really great..
Brings in a fix for a removed Kconfig name Signed-off-by: Jamie McCrae <[email protected]>
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
6411fee
into
zephyrproject-rtos:collab-hwm
Fixes a test which missed the rename of a board