Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmv2: tests: drivers: flash: Renamed missed board rename #69597

Merged

Conversation

nordicjm
Copy link
Collaborator

Fixes a test which missed the rename of a board

Fixes a test which missed the rename of a board

Signed-off-by: Jamie McCrae <[email protected]>
@zephyrbot zephyrbot added Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. area: Flash labels Feb 29, 2024
@zephyrbot zephyrbot requested a review from de-nordic February 29, 2024 07:52
@nordicjm nordicjm added this to the v3.7.0 milestone Feb 29, 2024
Adds a file back that was wrongly deleted in an unrelated
commit

Signed-off-by: Jamie McCrae <[email protected]>
boards/weact/stm32g431_core/weact_stm32g431_core_defconfig Outdated Show resolved Hide resolved
- stm32f3_disco
- stm32f3_disco@B
Copy link
Member

@erwango erwango Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is were this unclear to me. Is that required to define a revision in twister if a default is available ?
From your answer here this was not required, but then why doing such change ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Twister needs to define the revision to use yes because it uses the identifiers from the yaml files, this is to make it clear what revision is being built for. It is users that do not, you can continue building using west and cmake without the revision and it will use the default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so if one adds a revision to a board, all references to the board in twister should be renamed.... This isn't really great..

Brings in a fix for a removed Kconfig name

Signed-off-by: Jamie McCrae <[email protected]>
@zephyrbot
Copy link
Collaborator

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs pull/59/head zephyrproject-rtos/hal_silabs#60 zephyrproject-rtos/hal_silabs#60/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_silabs DNM This PR should not be merged (Do Not Merge) labels Feb 29, 2024
@nordicjm nordicjm removed the DNM This PR should not be merged (Do Not Merge) label Feb 29, 2024
@carlescufi carlescufi merged commit 6411fee into zephyrproject-rtos:collab-hwm Feb 29, 2024
22 of 28 checks passed
@nordicjm nordicjm deleted the hwmv2-fix-stm32test branch July 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Flash manifest manifest-hal_silabs Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants