net: Add more specific dependencies for specialized samples #69295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
canisLupus1313,
edmont,
a user,
jukkar,
kartben,
maciejbaczmanski,
mariuszpos,
nashif,
pdgendt,
ssharks and
tbursztyka
canisLupus1313
previously approved these changes
Feb 21, 2024
maciejbaczmanski
previously approved these changes
Feb 21, 2024
pdgendt
previously approved these changes
Feb 21, 2024
edmont
previously approved these changes
Feb 21, 2024
rlubos
dismissed stale reviews from edmont, pdgendt, maciejbaczmanski, and canisLupus1313
via
186e5c7
rlubos
force-pushed
the
net/sample-yml-dependency-clarification
branch
from
183df65 to
186e5c7
Compare
|
Sorry, had to push again, as apparently I've misinterpreted the twister syntax, which resulted in a spectacular CI failure. |
pdgendt
previously approved these changes
Feb 21, 2024
edmont
previously approved these changes
Feb 21, 2024
kartben
approved these changes
Feb 21, 2024
kartben
previously approved these changes
Feb 21, 2024
jukkar
previously approved these changes
Feb 22, 2024
|
@rlubos please rebase |
Certain samples are supposed to demonstrate technology-specific features, therefore their dependencies in sample.yml could be narrowed to run verify build only on boards which support that specific technology (like Ethernet or OpenThread). Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
net/sample-yml-dependency-clarification
branch
from
186e5c7 to
30348ac
Compare
Done |
kartben
approved these changes
Mar 5, 2024
pdgendt
approved these changes
Mar 5, 2024
jukkar
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain samples are supposed to demonstrate technology-specific features, therefore their dependencies in sample.yml could be narrowed to verify build only on boards which support that specific technology (like Ethernet or OpenThread).
Resolves #51079