Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: tests: Improve accuracy of required dependencies in networking tests #51079

Closed
katgiadla opened this issue Oct 7, 2022 · 3 comments · Fixed by #69295
Closed

samples: tests: Improve accuracy of required dependencies in networking tests #51079

katgiadla opened this issue Oct 7, 2022 · 3 comments · Fixed by #69295
Assignees
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features

Comments

@katgiadla
Copy link
Collaborator

Problem description:
Majority of the networking testcases require any network interface - this requirement is specified in testsuite YAML by using keyword netif.
On the boards, which support this feature, it is possible to build and/or execute test configuration.

Some test suites assume that specific networking technology will be used (example for Ethernet and for OpenThread).

Unfortunatelly, these technologies are not accurate specified. It means, samples/tests are build and/or execute on the boards, which does not support specified technology but support any network interface.

Solution:
Clarify, which network feature is required in testsuites/sample by changing field depends_on.
e.g. example for Ethernet

Currently:
depends_on: netif

Change into:
depends_on: eth

@katgiadla katgiadla added the Enhancement Changes/Updates/Additions to existing features label Oct 7, 2022
@zephyrbot
Copy link
Collaborator

Hi @rlubos,

This issue, marked as an Enhancement, was opened a while ago and did not get any traction. Please confirm the issue is correctly assigned and re-assign it otherwise.

Please take a moment to review if the issue is still relevant to the project. If it is, please provide feedback and direction on how to move forward. If it is not, has already been addressed, is a duplicate, or is no longer relevant, please close it with a short comment explaining the reason.

@katgiadla you are also encouraged to help moving this issue forward by providing additional information and confirming this request/issue is still relevant to you.

Thanks!

@rlubos
Copy link
Contributor

rlubos commented Feb 21, 2024

For samples. I've opened #69295 to narrow the testing scope for the specialized ones (mostly Ethernet stuff, the only OT speicifc is the linked one).

As for the tests, I've looked them over but I'm not really sure we should change anything there. All of the tests we have (unless I missed something) do not really depend on the actual hardware, as they operate on fake interfaces they create.

@jukkar
Copy link
Member

jukkar commented Feb 22, 2024

Also after #69244 the tests should run without any board specific Ethernet interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants