drivers: serial: nrfx_uarte2: Fixes in the new nordic shim #68630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: nRF
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
|
Thanks Krzysztof, it looks fine enough to me. Should we aim at 3.6? (I set the milestone assuming so, please change it if you diagree) |
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
from
a3f573b to
bbb4d18
Compare
anangl
reviewed
Feb 12, 2024
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
2 times, most recently
from
ff38d0b to
5b29a45
Compare
dcpleung
previously approved these changes
Mar 7, 2024
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
from
5b29a45 to
3ca7686
Compare
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
from
3ca7686 to
015c47b
Compare
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
from
015c47b to
2899fe9
Compare
anangl
approved these changes
Apr 4, 2024
carlescufi
approved these changes
Apr 4, 2024
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
from
2899fe9 to
da220ed
Compare
Move providing of the first buffer in uart_rx_enable from that function to the callback which is called from nrfx_uarte_rx_enable context. By doing this nrfx_uarte_rx_buffer_set is called when RX configuration flags are already known to the driver. Signed-off-by: Krzysztof Chruściński <[email protected]>
Tests which were using the new nordic UART shim where failing on the bsim targets. They are now fixed and tests can be re-enabled. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
nrf_uart_shim_fixes
branch
from
da220ed to
c71fa9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of fixes for new UART shim. After those fixes tests with new shim can be re-enabled on CI for nordic bsim targets.
Fixes #67890.