Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v3.6-branch] drivers: serial: nrfx_uarte2: Fixes in the new nordic shim #71129

Closed
wants to merge 3 commits into from

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Apr 5, 2024

Backport 362389e~2..362389e from #68630.

Fixes: #67890

Move providing of the first buffer in uart_rx_enable from that
function to the callback which is called from nrfx_uarte_rx_enable
context. By doing this nrfx_uarte_rx_buffer_set is called when
RX configuration flags are already known to the driver.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit 7bededb)
Tests which were using the new nordic UART shim where failing
on the bsim targets. They are now fixed and tests can be
re-enabled.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit 362389e)
@zephyrbot zephyrbot requested a review from anangl as a code owner April 5, 2024 10:22
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues area: UART Universal Asynchronous Receiver-Transmitter platform: nRF Nordic nRFx labels Apr 5, 2024
@zephyrbot zephyrbot requested a review from dcpleung April 5, 2024 10:23
@dcpleung
Copy link
Member

dcpleung commented Apr 5, 2024

This needs a bug/issue filed first.

@MaureenHelm
Copy link
Member

@nordic-krch @aescolar can you look at the CI failure?

Equivalent to a squash of main's commits:
e36d15c
54014f5
fa3f2ee

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@zephyrbot
Copy link
Collaborator Author

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nordic zephyrproject-rtos/hal_nordic@dce8519 zephyrproject-rtos/hal_nordic@13ac55b zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@aescolar
Copy link
Member

An updated nordic hal is required as that also got several bugfixes for this driver.

@henrikbrixandersen
Copy link
Member

An updated nordic hal is required as that also got several bugfixes for this driver.

That update pulls in quite a few other, seemingly unrelated, changes. Is this intended? It kind of circumvents our backport process, as these changes do not have a bug report issue to justify them being backported.

@aescolar
Copy link
Member

aescolar commented May 1, 2024

That update pulls in quite a few other, seemingly unrelated, changes.

It is due to the resolution we have in the HAL repo..
Actually, @henrikbrixandersen what was the motivation to add the backport label to the original PR?
@nordic-krch is this driver considered stable enough in 3.6 to need a backport?

@henrikbrixandersen
Copy link
Member

Actually, @henrikbrixandersen what was the motivation to add the backport label to the original PR?

This label was added to open bugfix PRs targeting v3.6.0 that didn't make it in before the release. If this particular fix should not be backported, feel free to close this PR.

@aescolar aescolar added the DNM This PR should not be merged (Do Not Merge) label May 2, 2024
@nordic-krch
Copy link
Contributor

I think that it does not make sense to backport it. Driver is mainly used by nrf54h20 and nrf54l15 which are in early phase of development and no one will use 3.6 release for a product.

@nordic-krch nordic-krch closed this May 6, 2024
@nashif nashif deleted the backport-68630-to-v3.6-branch branch November 16, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter Backport Backport PR and backport failure issues DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nordic platform: nRF Nordic nRFx
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants