-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport v3.6-branch] drivers: serial: nrfx_uarte2: Fixes in the new nordic shim #71129
Conversation
Move providing of the first buffer in uart_rx_enable from that function to the callback which is called from nrfx_uarte_rx_enable context. By doing this nrfx_uarte_rx_buffer_set is called when RX configuration flags are already known to the driver. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 7bededb)
Tests which were using the new nordic UART shim where failing on the bsim targets. They are now fixed and tests can be re-enabled. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 362389e)
This needs a bug/issue filed first. |
@nordic-krch @aescolar can you look at the CI failure? |
Equivalent to a squash of main's commits: e36d15c 54014f5 fa3f2ee Signed-off-by: Alberto Escolar Piedras <[email protected]>
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
An updated nordic hal is required as that also got several bugfixes for this driver. |
That update pulls in quite a few other, seemingly unrelated, changes. Is this intended? It kind of circumvents our backport process, as these changes do not have a bug report issue to justify them being backported. |
It is due to the resolution we have in the HAL repo.. |
This label was added to open bugfix PRs targeting v3.6.0 that didn't make it in before the release. If this particular fix should not be backported, feel free to close this PR. |
I think that it does not make sense to backport it. Driver is mainly used by nrf54h20 and nrf54l15 which are in early phase of development and no one will use 3.6 release for a product. |
Backport 362389e~2..362389e from #68630.
Fixes: #67890