Bluetooth: tbs: change notifications #68367
Conversation
piotrnarajowski
force-pushed
the
my_notify_cb
branch
2 times, most recently
from
542ea51 to
ba8f6a6
Compare
piotrnarajowski
force-pushed
the
my_notify_cb
branch
from
ba8f6a6 to
17a3025
Compare
|
@Thalley This is an RFC, could you please take a look? Came across this issue while going through TBS tests that require updating characteristic values with value len > ATT_MTU-3. Without this workaround, bt_gatt_notify_uuid doesn't work and returns -ENOMEM |
The approach is fine, but needs a bit more love to make it more readable. Effectively this is truncating the notifications to fit in the MTU. I would suggest to make a generic notify function so you only need to have the truncating code once, and then properly describe the magic numbers used. See e.g. https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/audio/ascs.c#L177-L218 for inspiration, as that effectively does the same. |
Change notifications for tbs functions work in progress Signed-off-by: Piotr Narajowski <[email protected]>
piotrnarajowski
force-pushed
the
my_notify_cb
branch
from
1218ae0 to
76873ac
Compare
|
@Thalley I can't realy find the way to make one generic ntf function... |
I don't have a line-by-line solution either, but possible the way that MCS implements it could be useful as inspiration: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/audio/mcs.c#L965-L995 |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Change notifications for tbs functions. This is needed to reproduce this issue.
work in progress