Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: TBS: Value Changed During Long Read error code #68173

Open
piotrnarajowski opened this issue Jan 26, 2024 · 13 comments
Open

Bluetooth: TBS: Value Changed During Long Read error code #68173

piotrnarajowski opened this issue Jan 26, 2024 · 13 comments
Assignees
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@piotrnarajowski
Copy link
Contributor

piotrnarajowski commented Jan 26, 2024

Describe the bug
These test cases verify the behavior of the server IUT when we update TBS characteristics with value greater then ATT_MTU-3. We change the value of characteristic (e.g. Bearer Provider Name) with value len greater than ATT_MTU-3. PTS then reads the characteristic value by executing GATT Read Long Characteristic Value with offset set to 0. By the time there is second long read request with a Value Offset of (ATT_MTU-3), we change the value one more time. Zephyr server IUT doesn't respond with Value Changed During Read Long (0x80) error code.

To Reproduce
Can be reproduced with AutoPTS.

Expected behavior
According to TBS spec, section 1.4:

The server shall return an ATT Error Response with the application error code Value Changed During Read Long (0x80) as defined in Table 1.2 to any ATT_READ_BLOB_REQ with a non-zero Value Offset ifthe characteristic value has changed since the last zero offset read response of that characteristic value to that client.

Impact
Failing test cases:
TBS/SR/SPN/BV-05-C
TBS/SR/SPN/BV-06-C
TBS/SR/SPN/BV-07-C
TBS/SR/SPN/BV-08-C
TBS/SR/SPN/BV-09-C
TBS/SR/SPN/BV-10-C
TBS/SR/SPN/BV-11-C
Also same test cases with GTBS prefix

Logs and console output
TBS_SR_SPN_BV_05_C_2024_01_26_17_27_12.zip

Environment (please complete the following information):

@Thalley
Copy link
Collaborator

Thalley commented Feb 16, 2024

@piotrnarajowski how does your PR (#68367) relate to this? Your PR is required to trigger long reads, right? So this can't really be worked on, before your PR has been done (or at least the work should continue on top of your PR), right?

@piotrnarajowski
Copy link
Contributor Author

@Thalley Yes, PR #68367 is necessary to properly trigger long reads and to reproduce this issue. I'll try, but I'm not sure I will be able to finish it as LE Audio project is coming to an end for me.

@Thalley
Copy link
Collaborator

Thalley commented Mar 6, 2024

@piotrnarajowski Will your PR ever go out of draft, or will it be abandoned now?

@piotrnarajowski
Copy link
Contributor Author

@Thalley for now @sjanc will take a look at this, please assign him

@piotrnarajowski piotrnarajowski removed their assignment Mar 6, 2024
@Thalley Thalley assigned sjanc and unassigned Thalley Mar 6, 2024
@Thalley
Copy link
Collaborator

Thalley commented Mar 12, 2024

Related to #64175

@Thalley Thalley moved this from To do to In progress in Bluetooth LE Audio Apr 30, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label May 12, 2024
@sjanc sjanc removed the Stale label May 12, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@Thalley Thalley removed the Stale label Jul 12, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Sep 11, 2024
@sjanc sjanc removed the Stale label Sep 11, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Nov 11, 2024
@jhedberg jhedberg removed the Stale label Nov 11, 2024
@Thalley
Copy link
Collaborator

Thalley commented Nov 13, 2024

@sjanc any plan for this? It's one of the few open bugs we have for LE Audio, so would like to get it closed in the near future

@sjanc
Copy link
Collaborator

sjanc commented Nov 14, 2024

I'm not sure when I'll have time to look at this

@Thalley
Copy link
Collaborator

Thalley commented Nov 14, 2024

I'm not sure when I'll have time to look at this

No problem. I'll re-assign to me, and hopefully have a look at in soon

@Thalley Thalley assigned Thalley and unassigned sjanc Nov 14, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
Status: In progress
Development

No branches or pull requests

6 participants