Fix Build failures when compiling the NXP USB driver #67459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
dleach02,
jfischer-no,
manuargue,
PetervdPerk-NXP and
tmon-nordic
yvanderv
approved these changes
Jan 10, 2024
dleach02
approved these changes
Jan 10, 2024
tmon-nordic
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Is it necessary to revert both commits? Isn't 21c9c4a the only culprit?
Merged
Yes, both are related to the changes added as part of the PR to the USB HAL driver. |
… mcux driver" This reverts commit 21c9c4a. Signed-off-by: Mahesh Mahadevan <[email protected]>
@jfischer-no, that is how I reverted these commits. |
dleach02
added
the
Hotfix
Then the commit message would be easier to spot in the history and re-reverted. |
This reverts commit 2b91d62. Signed-off-by: Mahesh Mahadevan <[email protected]>
|
Updated the PR with the original revert commit messages. |
jfischer-no
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure introduced as part of PR #67261