Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: bump hal_nxp revision #67483

Merged
merged 1 commit into from
Feb 2, 2024
Merged

manifest: bump hal_nxp revision #67483

merged 1 commit into from
Feb 2, 2024

Conversation

jsiverskog
Copy link
Contributor

this brings in a newer version of the usb middleware.

see zephyrproject-rtos/hal_nxp#316 for more information.

@jsiverskog jsiverskog mentioned this pull request Jan 11, 2024
Merged
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 11, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@0463d6a zephyrproject-rtos/hal_nxp@d45b14c (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jan 11, 2024
@danieldegrasse
Copy link
Collaborator

@hakehuang could you run a regression test against this PR? Specifically to cover USB tests, since this will update the middleware (which effectively updates the HAL underlying the MCUX USB shim driver)

@hakehuang
Copy link
Collaborator

hakehuang commented Jan 18, 2024 •
edited
Loading

@hakehuang could you run a regression test against this PR? Specifically to cover USB tests, since this will update the middleware (which effectively updates the HAL underlying the MCUX USB shim driver)

@danieldegrasse all lpcxpresso55s28/mimxrt1170_evk_cm7/mimxrt595_evk_cm33 series usb build fails, which means lpc55, rt11xx, RT10xx, RTxxx series all failure, only pass on frdm_k64f
e.g
samples/subsys/shell/shell_module/sample.shell.shell_module.usb
Build failure

<style> </style>
CASE_NAME ZEPHYR_VERSION RESULT PLATFORM TEST_PATH
sample.shell.shell_module.usb zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/shell/shell_module
sample.usb.cdc-acm-composite zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/cdc_acm_composite
sample.usb.webusb zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/webusb
sample.usb.audio.headphones_microphone zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/audio/headphones_microphone
sample.usb.audio.headset zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/audio/headset
sample.usb.hid zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/hid
sample.usb.loopback zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/testusb
sample.usb.dfu zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/dfu
sample.usb.dfu.permanent.download zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/dfu
sample.usb.cdc-acm zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/cdc_acm
sample.usb.cdc-acm.comp zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/cdc_acm
sample.usb.hid-mouse zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/subsys/usb/hid-mouse
sample.net.zperf.netusb_ecm zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/net/zperf
sample.net.zperf.netusb_eem zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/net/zperf
sample.net.zperf.netusb_rndis zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/net/zperf
sample.net.sockets.dumb_http_server.netusb zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/net/sockets/dumb_http_server
sample.net.sockets.dumb_http_server.netusb_zeroconf zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 samples/net/sockets/dumb_http_server
drivers.uart.basic_api.cdc_acm zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 tests/drivers/uart/uart_basic_api
usb.desc_sections zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 tests/subsys/usb/desc_sections
usb.device zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 tests/subsys/usb/device
usb.bos zephyr-v3.5.0-3983-g5603fc4a2365 Build failure lpcxpresso55s28 tests/subsys/usb/bos

@mmahadevan108
Copy link
Collaborator

@jsiverskog , thank you for the contribution. Can you help take a look at the build failures reported by Hake during testing.

@jsiverskog
Copy link
Contributor Author

@mmahadevan108 : i think the build issues were caused by a PR that shouldn't have been merged, and was reverted by #67459

i have rebased onto main, and i can't see any build errors.

@jsiverskog jsiverskog mentioned this pull request Jan 22, 2024
Merged
@hakehuang
Copy link
Collaborator

hakehuang commented Jan 23, 2024 •
edited
Loading

@mmahadevan108 : i think the build issues were caused by a PR that shouldn't have been merged, and was reverted by #67459

i have rebased onto main, and i can't see any build errors.

retesting at my side. all tests are PASS on rt10/RT5xx/LPC series

hakehuang
hakehuang previously approved these changes Jan 23, 2024
View reviewed changes
@danieldegrasse
Copy link
Collaborator

@hakehuang can you reapprove if everything still looks good on this PR? It looks like the update here was just a rebase, so I'll leave it up to you to decide if we need to rerun tests

@hakehuang
Copy link
Collaborator

hakehuang commented Feb 1, 2024 •
edited
Loading

@hakehuang can you reapprove if everything still looks good on this PR? It looks like the update here was just a rebase, so I'll leave it up to you to decide if we need to rerun tests

@danieldegrasse , I run a regression test on
RT/kinets/LPC boards, no issues found.

but strange thing is I meet build failure on
lpcxpresso55s69_cpu0

/home/jenkins/agent/workspace/github_zephyr_build_ci_lpc/zephyr/drivers/i2s/i2s_mcux_flexcomm.c
/home/jenkins/agent/workspace/github_zephyr_build_ci_lpc/zephyr/drivers/i2s/i2s_mcux_flexcomm.c: In function 'i2s_mcux_configure':
/home/jenkins/agent/workspace/github_zephyr_build_ci_lpc/zephyr/drivers/i2s/i2s_mcux_flexcomm.c:272:25: error: implicit declaration of function 'I2S_EnableSecondaryChannel' [-Werror=implicit-function-declaration]
  272 |                         I2S_EnableSecondaryChannel(cfg->base, slot - 1, false,
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

@hakehuang hakehuang self-requested a review February 1, 2024 08:31
@danieldegrasse
Copy link
Collaborator

but strange thing is I meet build failure on
lpcxpresso55s69_cpu0

This one's on me, but should have been fixed by #68137

danieldegrasse
danieldegrasse previously approved these changes Feb 1, 2024
View reviewed changes
hakehuang
hakehuang previously approved these changes Feb 2, 2024
View reviewed changes
@mmahadevan108 mmahadevan108 self-assigned this Feb 2, 2024
mmahadevan108
mmahadevan108 previously approved these changes Feb 2, 2024
View reviewed changes
@mmahadevan108
Copy link
Collaborator

@jsiverskog , can you update west.yml to get the HAL SHA

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Feb 2, 2024
@jsiverskog @dleach02
manifest: bump hal_nxp revision
0436e49 
this brings in a newer version of the usb middleware.

see zephyrproject-rtos/hal_nxp#316 for more
information.

Signed-off-by: Jacob Siverskog <[email protected]>
@dleach02
Copy link
Member

dleach02 commented Feb 2, 2024

@jsiverskog, we merged your HAL PR and I updated your PR to have the SHA aligned.

@henrikbrixandersen henrikbrixandersen merged commit 031f84d into zephyrproject-rtos:main Feb 2, 2024
21 checks passed
@jsiverskog jsiverskog deleted the bump_nxp_hal_2 branch February 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleach02 dleach02 dleach02 approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@decsny decsny Awaiting requested review from decsny

@hakehuang hakehuang Awaiting requested review from hakehuang

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

Assignees

@mmahadevan108 mmahadevan108

Labels
manifest manifest-hal_nxp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsiverskog @zephyrbot @danieldegrasse @hakehuang @mmahadevan108 @dleach02 @henrikbrixandersen