Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[65183] sam0: initialize GCLK2 in wdt_sam0_init #65211

Merged

Conversation

vlm-laba7
Copy link
Contributor

@vlm-laba7 vlm-laba7 commented Nov 15, 2023

Initialize GCLK2 to output 1.024kHz required by watchdog timer.

Fixes: #65183

Copy link

Hello @vlm-laba7, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@attie-argentum
Copy link
Member

Thanks for the patch!

This would probably fit better in soc/arm/atmel_sam0/common/soc_samd2x.c, where GCLK Gen 2 is indeed marked up for the WDT.

@nandojve
Copy link
Member

Hi @vlm-laba7 ,

Please, rebase on top of main and make sure CI is green.

@attie-argentum , could you revisit this?

attie-argentum
attie-argentum previously approved these changes Nov 26, 2023
pdgendt
pdgendt previously approved these changes Nov 27, 2023
@nandojve
Copy link
Member

Hi @vlm-laba7 ,

Make sure you fix compliance check otherwise it is not possible to merge your PR:

Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 d5b2a263d918263113ce3203a5291c5b04f0bfbd: author email (vlm <[email protected]>) needs to match one of the signed-off-by entries.
d5b2a[26](https://github.com/zephyrproject-rtos/zephyr/actions/runs/6877251017/job/18754400492?pr=65211#step:9:27)3d918263113ce3203a5291c5b04f0bfbd: author email (vlm <[email protected]>) does not follow the syntax: First Last <email>.

@vlm-laba7 vlm-laba7 force-pushed the 65183-sam0-wdt-clock branch from 70f1370 to 91f3c8f Compare November 27, 2023 07:57
@vlm-laba7
Copy link
Contributor Author

@nandojve done

soc/arm/atmel_sam0/common/soc_samd2x.c Outdated Show resolved Hide resolved
@vlm-laba7 vlm-laba7 dismissed stale reviews from attie-argentum and pdgendt via 5307aa9 November 30, 2023 10:38
@vlm-laba7 vlm-laba7 force-pushed the 65183-sam0-wdt-clock branch from 91f3c8f to 5307aa9 Compare November 30, 2023 10:38
@vlm-laba7 vlm-laba7 force-pushed the 65183-sam0-wdt-clock branch 2 times, most recently from 6c86756 to 257961b Compare November 30, 2023 10:46
@stephanosio
Copy link
Member

Signed-off-by: Vlad Laba7 [email protected]

@vlm-laba7 Unless your last name actually contains 7, please use your full name as required by the DCO policy.

@vlm-laba7
Copy link
Contributor Author

@stephanosio sorry, I prefer not to use any names on this account - feel free to author this commit

@nandojve
Copy link
Member

Hi @kartben,

@stephanosio sorry, I prefer not to use any names on this account - feel free to author this commit

Do you know who can help to clarify this?

@kartben
Copy link
Collaborator

kartben commented Jan 15, 2024

feel free to author this commit

Unfortunately I don't think we can accept contributions not covered by the DCO, as that's how the contributor acknowledges they have the rights to contribute the code to Zephyr under the Apache 2.0 License.

@nandojve
Copy link
Member

feel free to author this commit

Unfortunately I don't think we can accept contributions not covered by the DCO, as that's how the contributor acknowledges they have the rights to contribute the code to Zephyr under the Apache 2.0 License.

This means that someone should open another PR with a solution and we need to close this, right?

@martinjaeger
Copy link
Member

feel free to author this commit

Unfortunately I don't think we can accept contributions not covered by the DCO, as that's how the contributor acknowledges they have the rights to contribute the code to Zephyr under the Apache 2.0 License.

This means that someone should open another PR with a solution and we need to close this, right?

You can also edit this PR in place as a maintainer. Just add @vlm-laba7's repo as a new remote in git and force-push to the branch as usual.

@nandojve nandojve force-pushed the 65183-sam0-wdt-clock branch from 257961b to c268f65 Compare January 20, 2024 11:27
Initialize GCLK2 to output 1.024kHz required by watchdog timer.

Co-authored-by: Vlad Laba7 <[email protected]>
Signed-off-by: Gerson Fernando Budke <[email protected]>
Copy link
Member

@attie-argentum attie-argentum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested (I don't have the hardware), but looks sensible to me - thanks!

@henrikbrixandersen henrikbrixandersen merged commit 5903c7a into zephyrproject-rtos:main Feb 5, 2024
17 checks passed
Copy link

github-actions bot commented Feb 5, 2024

Hi @vlm-laba7!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Watchdog Watchdog platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samd21: wdt clock is not initialized correctly
9 participants