-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[65183] sam0: initialize GCLK2 in wdt_sam0_init #65211
[65183] sam0: initialize GCLK2 in wdt_sam0_init #65211
Conversation
Hello @vlm-laba7, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please reformat the Git commit log to follow the project standard (please see https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines) and add a DCO sign-off (see https://docs.zephyrproject.org/latest/contribute/guidelines.html#developer-certification-of-origin-dco).
fb7545f
to
8a83e2c
Compare
Thanks for the patch! This would probably fit better in |
8a83e2c
to
70f1370
Compare
Hi @vlm-laba7 , Please, rebase on top of main and make sure CI is green. @attie-argentum , could you revisit this? |
Hi @vlm-laba7 , Make sure you fix compliance check otherwise it is not possible to merge your PR:
|
70f1370
to
91f3c8f
Compare
@nandojve done |
5307aa9
91f3c8f
to
5307aa9
Compare
6c86756
to
257961b
Compare
@vlm-laba7 Unless your last name actually contains |
@stephanosio sorry, I prefer not to use any names on this account - feel free to author this commit |
Hi @kartben,
Do you know who can help to clarify this? |
Unfortunately I don't think we can accept contributions not covered by the DCO, as that's how the contributor acknowledges they have the rights to contribute the code to Zephyr under the Apache 2.0 License. |
This means that someone should open another PR with a solution and we need to close this, right? |
You can also edit this PR in place as a maintainer. Just add @vlm-laba7's repo as a new remote in git and force-push to the branch as usual. |
257961b
to
c268f65
Compare
Initialize GCLK2 to output 1.024kHz required by watchdog timer. Co-authored-by: Vlad Laba7 <[email protected]> Signed-off-by: Gerson Fernando Budke <[email protected]>
c268f65
to
d996fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested (I don't have the hardware), but looks sensible to me - thanks!
Hi @vlm-laba7! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Initialize GCLK2 to output 1.024kHz required by watchdog timer.
Fixes: #65183