Bluetooth: TBS: Ensure sending notifications #82775
Open
+875
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
tbs_notifications_refactor
branch
3 times, most recently
from
6487dce to
36b1833
Compare
Thalley
force-pushed
the
tbs_notifications_refactor
branch
4 times, most recently
from
873f780 to
25228c9
Compare
|
#AutoPTS run zephyr nrf53 TBS |
|
Scheduled PR #82775 (comment), board: nrf53, estimated start time: 13:44:42, test case count: 45, estimated duration: 1:12:09 Test cases to be runTBS/SR/SGGIT/SER/BV-01-CTBS/SR/SGGIT/CHA/BV-01-C TBS/SR/SGGIT/CHA/BV-02-C TBS/SR/SGGIT/CHA/BV-03-C TBS/SR/SGGIT/CHA/BV-04-C TBS/SR/SGGIT/CHA/BV-05-C TBS/SR/SGGIT/CHA/BV-06-C TBS/SR/SGGIT/CHA/BV-07-C TBS/SR/SGGIT/CHA/BV-08-C TBS/SR/SGGIT/CHA/BV-09-C TBS/SR/SGGIT/CHA/BV-10-C TBS/SR/SGGIT/CHA/BV-11-C TBS/SR/SGGIT/CHA/BV-12-C TBS/SR/SGGIT/CHA/BV-13-C TBS/SR/SGGIT/CHA/BV-14-C TBS/SR/SGGIT/CHA/BV-15-C TBS/SR/SGGIT/CHA/BV-16-C TBS/SR/CP/BV-01-C TBS/SR/CP/BV-02-C TBS/SR/CP/BV-03-C TBS/SR/CP/BV-04-C TBS/SR/CP/BV-05-C TBS/SR/CP/BV-06-C TBS/SR/CP/BV-07-C TBS/SR/CP/BV-08-C TBS/SR/CP/BV-09-C TBS/SR/CP/BV-10-C TBS/SR/SP/BV-01-C TBS/SR/SP/BV-02-C TBS/SR/SPN/BV-01-C TBS/SR/SPN/BV-02-C TBS/SR/SPN/BV-03-C TBS/SR/SPN/BV-04-C TBS/SR/SPN/BV-05-C TBS/SR/SPN/BV-06-C TBS/SR/SPN/BV-07-C TBS/SR/SPN/BV-08-C TBS/SR/SPN/BV-09-C TBS/SR/SPN/BV-10-C TBS/SR/SPN/BV-11-C TBS/SR/SPE/BI-01-C TBS/SR/SPE/BI-02-C TBS/SR/SPE/BI-03-C TBS/SR/SPE/BI-04-C TBS/SR/SPE/BI-05-C |
Thalley
force-pushed
the
tbs_notifications_refactor
branch
from
25228c9 to
3211c04
Compare
|
AutoPTS Bot results: Failed tests (25)TBS TBS/SR/CP/BV-01-C INDCSVTBS TBS/SR/CP/BV-02-C INDCSV TBS TBS/SR/CP/BV-03-C INDCSV TBS TBS/SR/CP/BV-04-C INDCSV TBS TBS/SR/CP/BV-05-C INDCSV TBS TBS/SR/CP/BV-06-C INDCSV TBS TBS/SR/CP/BV-07-C INDCSV TBS TBS/SR/CP/BV-08-C INDCSV TBS TBS/SR/CP/BV-09-C INDCSV TBS TBS/SR/CP/BV-10-C INDCSV - ERRATA https://github.com//issues/41738 Disallow Join not possible at runtime TBS TBS/SR/SPE/BI-01-C INDCSV TBS TBS/SR/SPE/BI-02-C INDCSV TBS TBS/SR/SPE/BI-03-C INDCSV TBS TBS/SR/SPE/BI-05-C INDCSV - ERRATA TSE24847 TBS TBS/SR/SPN/BV-01-C INDCSV TBS TBS/SR/SPN/BV-02-C INDCSV TBS TBS/SR/SPN/BV-03-C INDCSV TBS TBS/SR/SPN/BV-04-C INDCSV TBS TBS/SR/SPN/BV-05-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-06-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-07-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-08-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-09-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-10-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-11-C INDCSV - ERRATA Request ID 31633 Successful tests (20)TBS TBS/SR/SGGIT/CHA/BV-01-C PASSTBS TBS/SR/SGGIT/CHA/BV-02-C PASS TBS TBS/SR/SGGIT/CHA/BV-03-C PASS TBS TBS/SR/SGGIT/CHA/BV-04-C PASS TBS TBS/SR/SGGIT/CHA/BV-05-C PASS TBS TBS/SR/SGGIT/CHA/BV-06-C PASS TBS TBS/SR/SGGIT/CHA/BV-07-C PASS TBS TBS/SR/SGGIT/CHA/BV-08-C PASS TBS TBS/SR/SGGIT/CHA/BV-09-C PASS TBS TBS/SR/SGGIT/CHA/BV-10-C PASS TBS TBS/SR/SGGIT/CHA/BV-11-C PASS TBS TBS/SR/SGGIT/CHA/BV-12-C PASS TBS TBS/SR/SGGIT/CHA/BV-13-C PASS TBS TBS/SR/SGGIT/CHA/BV-14-C PASS TBS TBS/SR/SGGIT/CHA/BV-15-C PASS TBS TBS/SR/SGGIT/CHA/BV-16-C PASS TBS TBS/SR/SGGIT/SER/BV-01-C PASS TBS TBS/SR/SP/BV-01-C PASS TBS TBS/SR/SP/BV-02-C PASS TBS TBS/SR/SPE/BI-04-C PASS |
Thalley
force-pushed
the
tbs_notifications_refactor
branch
from
3211c04 to
a3e4fd3
Compare
|
#AutoPTS run zephyr nrf53 TBS |
|
Scheduled PR #82775 (comment), board: nrf53, estimated start time: 14:25:03, test case count: 45, estimated duration: 1:12:09 Test cases to be runTBS/SR/SGGIT/SER/BV-01-CTBS/SR/SGGIT/CHA/BV-01-C TBS/SR/SGGIT/CHA/BV-02-C TBS/SR/SGGIT/CHA/BV-03-C TBS/SR/SGGIT/CHA/BV-04-C TBS/SR/SGGIT/CHA/BV-05-C TBS/SR/SGGIT/CHA/BV-06-C TBS/SR/SGGIT/CHA/BV-07-C TBS/SR/SGGIT/CHA/BV-08-C TBS/SR/SGGIT/CHA/BV-09-C TBS/SR/SGGIT/CHA/BV-10-C TBS/SR/SGGIT/CHA/BV-11-C TBS/SR/SGGIT/CHA/BV-12-C TBS/SR/SGGIT/CHA/BV-13-C TBS/SR/SGGIT/CHA/BV-14-C TBS/SR/SGGIT/CHA/BV-15-C TBS/SR/SGGIT/CHA/BV-16-C TBS/SR/CP/BV-01-C TBS/SR/CP/BV-02-C TBS/SR/CP/BV-03-C TBS/SR/CP/BV-04-C TBS/SR/CP/BV-05-C TBS/SR/CP/BV-06-C TBS/SR/CP/BV-07-C TBS/SR/CP/BV-08-C TBS/SR/CP/BV-09-C TBS/SR/CP/BV-10-C TBS/SR/SP/BV-01-C TBS/SR/SP/BV-02-C TBS/SR/SPN/BV-01-C TBS/SR/SPN/BV-02-C TBS/SR/SPN/BV-03-C TBS/SR/SPN/BV-04-C TBS/SR/SPN/BV-05-C TBS/SR/SPN/BV-06-C TBS/SR/SPN/BV-07-C TBS/SR/SPN/BV-08-C TBS/SR/SPN/BV-09-C TBS/SR/SPN/BV-10-C TBS/SR/SPN/BV-11-C TBS/SR/SPE/BI-01-C TBS/SR/SPE/BI-02-C TBS/SR/SPE/BI-03-C TBS/SR/SPE/BI-04-C TBS/SR/SPE/BI-05-C |
|
AutoPTS Bot results: Failed tests (10)TBS TBS/SR/CP/BV-09-C INDCSVTBS TBS/SR/CP/BV-10-C INDCSV - ERRATA https://github.com//issues/41738 Disallow Join not possible at runtime TBS TBS/SR/SPE/BI-05-C INDCSV - ERRATA TSE24847 TBS TBS/SR/SPN/BV-05-C FAIL - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-06-C INDCSV - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-07-C FAIL - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-08-C FAIL - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-09-C FAIL - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-10-C FAIL - ERRATA Request ID 31633 TBS TBS/SR/SPN/BV-11-C FAIL - ERRATA Request ID 31633 Successful tests (35)TBS TBS/SR/CP/BV-01-C PASSTBS TBS/SR/CP/BV-02-C PASS TBS TBS/SR/CP/BV-03-C PASS TBS TBS/SR/CP/BV-04-C PASS TBS TBS/SR/CP/BV-05-C PASS TBS TBS/SR/CP/BV-06-C PASS TBS TBS/SR/CP/BV-07-C PASS TBS TBS/SR/CP/BV-08-C PASS TBS TBS/SR/SGGIT/CHA/BV-01-C PASS TBS TBS/SR/SGGIT/CHA/BV-02-C PASS TBS TBS/SR/SGGIT/CHA/BV-03-C PASS TBS TBS/SR/SGGIT/CHA/BV-04-C PASS TBS TBS/SR/SGGIT/CHA/BV-05-C PASS TBS TBS/SR/SGGIT/CHA/BV-06-C PASS TBS TBS/SR/SGGIT/CHA/BV-07-C PASS TBS TBS/SR/SGGIT/CHA/BV-08-C PASS TBS TBS/SR/SGGIT/CHA/BV-09-C PASS TBS TBS/SR/SGGIT/CHA/BV-10-C PASS TBS TBS/SR/SGGIT/CHA/BV-11-C PASS TBS TBS/SR/SGGIT/CHA/BV-12-C PASS TBS TBS/SR/SGGIT/CHA/BV-13-C PASS TBS TBS/SR/SGGIT/CHA/BV-14-C PASS TBS TBS/SR/SGGIT/CHA/BV-15-C PASS TBS TBS/SR/SGGIT/CHA/BV-16-C PASS TBS TBS/SR/SGGIT/SER/BV-01-C PASS TBS TBS/SR/SP/BV-01-C PASS TBS TBS/SR/SP/BV-02-C PASS TBS TBS/SR/SPE/BI-01-C PASS TBS TBS/SR/SPE/BI-02-C PASS TBS TBS/SR/SPE/BI-03-C PASS TBS TBS/SR/SPE/BI-04-C PASS TBS TBS/SR/SPN/BV-01-C PASS TBS TBS/SR/SPN/BV-02-C PASS TBS TBS/SR/SPN/BV-03-C PASS TBS TBS/SR/SPN/BV-04-C PASS |
Thalley
force-pushed
the
tbs_notifications_refactor
branch
2 times, most recently
from
287a8b9 to
e503788
Compare
|
The PTS tests will fail until #83959 is merged, but it is otherwise ready for review |
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot and
larsgk
The existing implemented only attempted to send all notifications, but if host was out of ATT TX buffers the notifications would fail and the client may miss out on important information, and would be a spec violation. This commit refactors notificatios in TBS so that they are always sent. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
tbs_notifications_refactor
branch
from
e503788 to
a8c0e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implemented only attempted to send all notifications, but if host was out of ATT TX buffers the notifications would fail and the client may miss out on important information, and would be a spec violation.
This commit refactors notificatios in TBS so that they are always sent.
depends on #83959
required for #68173