Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out protocol constants and value types into a zcash_protocol crate. #1142

Merged
merged 18 commits into from
Mar 6, 2024

Fix incorrect zip321 amount parsing.

376db46
Select commit
Loading
Failed to load commit list.
Merged

Factor out protocol constants and value types into a zcash_protocol crate. #1142

Fix incorrect zip321 amount parsing.
376db46
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 6, 2024 in 0s

64.82% of diff hit (target 64.33%)

View this Pull Request on Codecov

64.82% of diff hit (target 64.33%)

Annotations

Check warning on line 100 in components/zcash_address/src/encoding.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_address/src/encoding.rs#L100

Added line #L100 was not covered by tests

Check warning on line 113 in components/zcash_address/src/encoding.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_address/src/encoding.rs#L113

Added line #L113 was not covered by tests

Check warning on line 216 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L216

Added line #L216 was not covered by tests

Check warning on line 224 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L220-L224

Added lines #L220 - L224 were not covered by tests

Check warning on line 230 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L230

Added line #L230 was not covered by tests

Check warning on line 232 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L232

Added line #L232 was not covered by tests

Check warning on line 248 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L248

Added line #L248 was not covered by tests

Check warning on line 256 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L256

Added line #L256 was not covered by tests

Check warning on line 264 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L264

Added line #L264 was not covered by tests

Check warning on line 291 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L290-L291

Added lines #L290 - L291 were not covered by tests

Check warning on line 303 in components/zcash_protocol/src/consensus.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/consensus.rs#L302-L303

Added lines #L302 - L303 were not covered by tests

Check warning on line 50 in components/zcash_protocol/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/lib.rs#L47-L50

Added lines #L47 - L50 were not covered by tests

Check warning on line 44 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L42-L44

Added lines #L42 - L44 were not covered by tests

Check warning on line 116 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L115-L116

Added lines #L115 - L116 were not covered by tests

Check warning on line 128 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L125-L128

Added lines #L125 - L128 were not covered by tests

Check warning on line 130 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L130

Added line #L130 was not covered by tests

Check warning on line 150 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L149-L150

Added lines #L149 - L150 were not covered by tests

Check warning on line 158 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L157-L158

Added lines #L157 - L158 were not covered by tests

Check warning on line 174 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L173-L174

Added lines #L173 - L174 were not covered by tests

Check warning on line 190 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L189-L190

Added lines #L189 - L190 were not covered by tests

Check warning on line 221 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L217-L221

Added lines #L217 - L221 were not covered by tests

Check warning on line 274 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L272-L274

Added lines #L272 - L274 were not covered by tests

Check warning on line 299 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L298-L299

Added lines #L298 - L299 were not covered by tests

Check warning on line 311 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L310-L311

Added lines #L310 - L311 were not covered by tests

Check warning on line 333 in components/zcash_protocol/src/value.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/zcash_protocol/src/value.rs#L332-L333

Added lines #L332 - L333 were not covered by tests