Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out protocol constants and value types into a zcash_protocol crate. #1142

Merged
merged 18 commits into from
Mar 6, 2024
Merged

Factor out protocol constants and value types into a zcash_protocol crate. #1142

merged 18 commits into from
Mar 6, 2024

Commits on Mar 5, 2024

  1. Add stub for a zcash_protocol crate.

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    66c6bba View commit details
    Browse the repository at this point in the history

  2. Move zcash_primitives::{consensus, constants} to the `zcash_protoco… 

    …l` crate
    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    bacfe3c View commit details
    Browse the repository at this point in the history

  3. Move Amount and NonNegativeAmount types to the zcash_protocol c… 

    …rate.
    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5e4d9ab View commit details
    Browse the repository at this point in the history

  4. zcash_protocol: Rename value amounts to Zatoshis and ZatBalance

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7188482 View commit details
    Browse the repository at this point in the history

  5. zcash_protocol: Modify Zatoshis to directly wrap a u64

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    eb3c7b4 View commit details
    Browse the repository at this point in the history

  6. zcash_primitives: Move the local-consensus module to the `zcash_pro… 

    …tocol` crate.
    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    85d1ca2 View commit details
    Browse the repository at this point in the history

  7. Fix broken intra-doc links after zcash_protocol crate extraction.

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a35ccfc View commit details
    Browse the repository at this point in the history

  8. zcash_client_backend: Move the ShieldedProtocol and PoolType type… 

    …s to `zcash_protocol`
    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6445410 View commit details
    Browse the repository at this point in the history

  9. zcash_address: Use zcash_protocol::consensus::NetworkType 

    This inverts the dependency relationship between `zcash_protocol` and
`zcash_address`, permitting the network constants (primarily the HRPs)
defined in `zcash_protocol` to be used directly in `zcash_address`
instead of being duplicated.
    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4b18426 View commit details
    Browse the repository at this point in the history

  10. Expose address generation errors when constructing default addresses

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a823ed7 View commit details
    Browse the repository at this point in the history

  11. zcash_primitives: Move the memo module to the zcash_protocol crate.

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    04fdac7 View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review 

    Co-authored-by: str4d <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>
    @nuttycom @str4d @daira
    3 people committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b8aa513 View commit details
    Browse the repository at this point in the history

  13. Remove network_type calls that are obviated by the blanket impl.

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    51d4464 View commit details
    Browse the repository at this point in the history

  14. zcash_protocol: Use BalanceError instead of () for monetary range… 

    … violations.
    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5675a76 View commit details
    Browse the repository at this point in the history

  15. Add missing CHANGELOG entries.

    @nuttycom
    nuttycom committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8955cfc View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Daira-Emma Hopwood <[email protected]>
    @nuttycom @daira
    nuttycom and daira committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    eaabc0f View commit details
    Browse the repository at this point in the history

  2. Add failing test for incorrect zip321 amount parsing.

    @nuttycom
    nuttycom committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6b4942f View commit details
    Browse the repository at this point in the history

  3. Fix incorrect zip321 amount parsing.

    @nuttycom
    nuttycom committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    376db46 View commit details
    Browse the repository at this point in the history