Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated settings variable as per the defaults in the same file #121

Closed
wants to merge 1 commit into from

Conversation

Ballard-dev
Copy link

Updated settings variable as per the defaults in the same file which would cause a KeyError on line 148 in event_task_to_version_status.py when not setup

Changelog Description

From:

    asset_types_to_skip: list[str] = SettingsField(
        title="Skip on Asset types (short)",
        default_factory=list,
    )

To:

    asset_types_filter: list[str] = SettingsField(
        title="Skip on Asset types (short)",
        default_factory=list,
    )

Additional info

The defaults DEFAULT_SERVICE_HANDLERS_SETTINGS dictate that the modified variable name should now be correct.

Testing notes:

  1. Configure addon
  2. Sync
  3. Encounter KeyError

… cause a KeyError on line 148 in event_task_to_version_status.py when not setup
@Ballard-dev
Copy link
Author

Changes made here: #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant