Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event handlers: Status task to version settings #120

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 20, 2024

Changelog Description

Fix attribute name in settings model.

Additional info

Status to version settings model has correct attribute name asset_types_filter instead of asset_types_to_skip.

Testing notes:

  1. Task to version status propagation works.

@iLLiCiTiT iLLiCiTiT requested review from m-u-r-p-h-y and 64qam August 20, 2024 08:53
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Aug 20, 2024
@64qam 64qam added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 20, 2024
@iLLiCiTiT
Copy link
Member Author

DISCLAIMER: As I'm thinking about it, this may actually break stuff because of default settings Version > Task and Task > Version status sync. We should probably (at both places) have Allow list and Deny list, so it can work both ways.

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Aug 28, 2024
@iLLiCiTiT iLLiCiTiT closed this Aug 28, 2024
@iLLiCiTiT iLLiCiTiT force-pushed the bugfix/status-task-to-version-settings branch from a5dada1 to 4062344 Compare August 28, 2024 14:35
@iLLiCiTiT iLLiCiTiT reopened this Aug 28, 2024
@iLLiCiTiT
Copy link
Member Author

Changed the PR to simple fix similar to #121 and created new PR #123 with enahnced logic.

@iLLiCiTiT iLLiCiTiT merged commit 78833be into develop Sep 2, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/status-task-to-version-settings branch September 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants