Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Implement "limit by category" in AF4 #157

Merged
merged 8 commits into from
Mar 30, 2022
Merged

Implement "limit by category" in AF4 #157

merged 8 commits into from
Mar 30, 2022

Conversation

froboy
Copy link
Contributor

@froboy froboy commented Mar 25, 2022

#20 to work on #7 added a "Limit by category" field to the AF paragraph but didn't implement it. This implements that functionality as a step toward #103. Once we've validated that the logic here works with the Solr backend, then I'll continue work toward generalizing the functionality.

To test:

  • Enable openy_prgf_af4_demo and ensure solr is indexed
  • edit the AF4 paragraph and add an item to the "Limit by category" field.
  • observe AF is limited to only the selected categories
  • edit again and set the "Exclude by category"
  • retest and observe Exclude works as expected.
  • optional: it is technically possible to have both limit and exclude set, but in almost all circumstances this will result in an empty result.

@froboy froboy changed the title Implement limit by category in AF4 Implement "limit by category" in AF4 Mar 25, 2022
@podarok
Copy link
Contributor

podarok commented Mar 25, 2022

Looks good.
I'll check on builds next week.
Thank you @froboy

@podarok
Copy link
Contributor

podarok commented Mar 30, 2022

@froboy could you solve conflict issues, please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants