All activities are ignored when excludeByCategory and limitByCategory are empty.

[Sardis93]

#157 introduced a code that hides all activities when both
Limit by category and Exclude by category fields of the Activity Finder 4 block are not set.

Steps to reproduce:

• Enable openy_prgf_af4_demo and ensure solr is indexed
• edit the AF4 paragraph make sure the Limit by Category and Exclude by category are both empty.
• Go to Activity Finder and select "Activity" step.
• Observe absence of table compeletely.

[anpolimus]

This code now has no sense.
We are setting a variable to true at the beginning.
We are not changing it to false during the road and only returning that variable.
Let's double-check again if this PR changes anything.

[Sardis93]

So the logic behind this code is the following:

With let r = true

By default we allow any item from activityGroup to be passed by setting

let r = true

If the value is present in the excludeByCategory, then the

r = !this.excludeByCategory.includes(item.value.toString())

will result in false, thus not adding the item into the resulting filteredValue array.

Then the value is checked again using limitByCategory array.
If the value is missing in this array, then the

r = this.limitByCategory.includes(item.value.toString())

will return false once again, ensuring it is not in the resulting filteredValue.

With let r = false

Now let's consider the case where:

let r = false

And where excludeByCategory & limitByCategory are both empty, i.e. the condition

if (this.excludeByCategory.length)

and

if (this.limitByCategory.length)

are never passed.

The code never gets to checking
r = !this.excludeByCategory.includes(item.value.toString()) and r = this.limitByCategory.includes(item.value.toString())
And it never gets a chance to change the r to be true.

[anpolimus]

Sorry, you were right.
I've missed this line of code:
r = !this.excludeByCategory.includes(item.value.toString())

[anpolimus]

Sorry, you were right.
I've missed this line of code:
r = !this.excludeByCategory.includes(item.value.toString())

[shelleygoetz]

Fix added to March release https://yusa.atlassian.net/browse/DS-414