Improve action execution to have data in the action invocation success response

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/ActionInvocationResponseClassProvider.java

@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com).
+ *
+ * WSO2 LLC. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.wso2.carbon.identity.action.execution;
+
+import org.wso2.carbon.identity.action.execution.model.ActionType;
+import org.wso2.carbon.identity.action.execution.model.ResponseData;
+
+/**
+ * This interface is used to provide the classes for the action invocation responses defined by the downStream
+ * component.
+ */
+public interface ActionInvocationResponseClassProvider {
+
+    /**
+     * Get the supported action type for the public interface ActionInvocationResponseClassProvider.
+     *
+     * @return Supported action type.
+     */
+    ActionType getSupportedActionType();
+
+    /**
+     * Get the extended ResponseData class for action invocation success response defined by the downstream component.
+     *
+     * @return The extended ResponseData class.
+     */
+    Class<? extends ResponseData> getSuccessResponseContextClass();
+}

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/DefaultActionInvocationResponseClassProvider.java

@@ -0,0 +1,52 @@
+/*
+ * Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com).
+ *
+ * WSO2 LLC. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.wso2.carbon.identity.action.execution;
+
+import org.wso2.carbon.identity.action.execution.model.ActionType;
+import org.wso2.carbon.identity.action.execution.model.ResponseData;
+
+/**
+ * Default implementation of the ActionInvocationResponseClassProvider. The downStream components need to extend
+ * this class, when implementing the ActionInvocationResponseClassProvider.
+ */
+public class DefaultActionInvocationResponseClassProvider implements ActionInvocationResponseClassProvider {
+
+    static DefaultActionInvocationResponseClassProvider instance = new DefaultActionInvocationResponseClassProvider();
+
+    public static DefaultActionInvocationResponseClassProvider getInstance() {
+        return instance;
+    }
+
+    @Override
+    public ActionType getSupportedActionType() {
+
+        return null;
+    }
+
+    /**
+     * Get the default ResponseData class for action invocation success response.
+     *
+     * @return The default ResponseData class.
+     */
+    @Override
+    public Class<? extends ResponseData> getSuccessResponseContextClass() {
+
+        return ResponseData.DefaultResponseData.class;
+    }
+}

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImpl.java

@@ -307,7 +307,8 @@ private ActionInvocationResponse executeActionAsynchronously(Action action,
 
         String apiEndpoint = action.getEndpoint().getUri();
         CompletableFuture<ActionInvocationResponse> actionExecutor = CompletableFuture.supplyAsync(
-                () -> apiClient.callAPI(apiEndpoint, authenticationMethod, payload), executorService);
+                () -> apiClient.callAPI(ActionType.valueOf(action.getType().getActionType()),
+                        apiEndpoint, authenticationMethod, payload), executorService);
         try {
             return actionExecutor.get();
         } catch (InterruptedException | ExecutionException e) {

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionInvocationResponseClassFactory.java

@@ -0,0 +1,74 @@
+/*
+ * Copyright (c) 2024, WSO2 LLC. (http://www.wso2.com).
+ *
+ * WSO2 LLC. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.wso2.carbon.identity.action.execution.impl;
+
+import org.wso2.carbon.identity.action.execution.ActionInvocationResponseClassProvider;
+import org.wso2.carbon.identity.action.execution.DefaultActionInvocationResponseClassProvider;
+import org.wso2.carbon.identity.action.execution.model.ActionType;
+import org.wso2.carbon.identity.action.execution.model.ResponseData;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * This class defines the classes for action invocation responses for different action types.
+ * The ActionInvocationResponseClassFactory is the component that is responsible for providing the classes
+ * defined by the downstream component based on the action type.
+ */
+public class ActionInvocationResponseClassFactory {
+
+    private static final Map<ActionType, ActionInvocationResponseClassProvider> classProviders = new HashMap<>();
+
+    /**
+     * Register the ActionInvocationResponseClassProvider based on the action type.
+     *
+     * @param provider The ActionInvocationResponseClassProvider.
+     */
+    public static void registerActionInvocationResponseClassProvider(
+            ActionInvocationResponseClassProvider provider) {
+
+        classProviders.put(provider.getSupportedActionType(), provider);
+    }
+
+    /**
+     * Unregister the ActionInvocationResponseClassProvider based on the action type.
+     *
+     * @param provider The ActionInvocationResponseClassProvider.
+     */
+    public static void unregisterActionInvocationResponseClassProvider(
+            ActionInvocationResponseClassProvider provider) {
+
+        classProviders.remove(provider.getSupportedActionType());
+    }
+
+    /**
+     * Get the extended ResponseData class for invocation success response based on the action type.
+     *
+     * @param actionType Action type.
+     * @return The extended ResponseData class.
+     */
+    public static Class<? extends ResponseData> getInvocationSuccessResponseContextClass(ActionType actionType) {
+
+        ActionInvocationResponseClassProvider classProvider = classProviders.get(actionType);
+        if (classProvider != null) {
+            return classProvider.getSuccessResponseContextClass();
+        }
+        return DefaultActionInvocationResponseClassProvider.getInstance().getSuccessResponseContextClass();
+    }
+}

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/internal/ActionExecutionServiceComponent.java

@@ -31,9 +31,11 @@
 import org.wso2.carbon.identity.action.execution.ActionExecutionRequestBuilder;
 import org.wso2.carbon.identity.action.execution.ActionExecutionResponseProcessor;
 import org.wso2.carbon.identity.action.execution.ActionExecutorService;
+import org.wso2.carbon.identity.action.execution.ActionInvocationResponseClassProvider;
 import org.wso2.carbon.identity.action.execution.impl.ActionExecutionRequestBuilderFactory;
 import org.wso2.carbon.identity.action.execution.impl.ActionExecutionResponseProcessorFactory;
 import org.wso2.carbon.identity.action.execution.impl.ActionExecutorServiceImpl;
+import org.wso2.carbon.identity.action.execution.impl.ActionInvocationResponseClassFactory;
 import org.wso2.carbon.identity.action.management.service.ActionManagementService;
 import org.wso2.carbon.identity.rule.evaluation.service.RuleEvaluationService;
 
@@ -162,4 +164,30 @@ protected void unsetRuleEvaluationService(RuleEvaluationService ruleEvaluationSe
         LOG.debug("Unregistering reference for RuleEvaluationService in the ActionExecutionServiceComponent.");
         ActionExecutionServiceComponentHolder.getInstance().setRuleEvaluationService(ruleEvaluationService);
     }
+
+    @Reference(
+            name = "action.execution.response.ActionInvocationResponseClassProvider",
+            service = ActionInvocationResponseClassProvider.class,
+            cardinality = ReferenceCardinality.MULTIPLE,
+            policy = ReferencePolicy.DYNAMIC,
+            unbind = "unsetInvocationSuccessResponseContextClass"
+    )
+    protected void setInvocationSuccessResponseContextClass(ActionInvocationResponseClassProvider classProvider) {
+
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Registering ActionInvocationResponseClassProvider: " +
+                    classProvider.getClass().getName() + " in the ActionExecutionServiceComponent.");
+        }
+        ActionInvocationResponseClassFactory.registerActionInvocationResponseClassProvider(
+                classProvider);
+    }
+
+    protected void unsetInvocationSuccessResponseContextClass(ActionInvocationResponseClassProvider classProvider) {
+
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Unregistering ActionInvocationResponseClassProvider: " +
+                    classProvider.getClass().getName() + " in the ActionExecutionServiceComponent.");
+        }
+        ActionInvocationResponseClassFactory.unregisterActionInvocationResponseClassProvider(classProvider);
+    }
 }

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java

@@ -22,6 +22,7 @@
 import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
 import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
 
+import java.util.ArrayList;
 import java.util.List;
 
 /**
@@ -32,13 +33,14 @@
 public class ActionInvocationSuccessResponse implements ActionInvocationResponse.APIResponse {
 
     private final ActionInvocationResponse.Status actionStatus;
-
     private final List<PerformableOperation> operations;
+    private final ResponseData data;
 
     private ActionInvocationSuccessResponse(Builder builder) {
 
         this.actionStatus = builder.actionStatus;
         this.operations = builder.operations;
+        this.data = builder.data;
     }
 
     @Override
@@ -52,14 +54,20 @@ public List<PerformableOperation> getOperations() {
         return operations;
     }
 
+    public ResponseData getData() {
+
+        return data;
+    }
+
     /**
      * This class is used to build the {@link ActionInvocationSuccessResponse}.
      */
     @JsonPOJOBuilder(withPrefix = "")
     public static class Builder {
 
         private ActionInvocationResponse.Status actionStatus;
-        private List<PerformableOperation> operations;
+        private List<PerformableOperation> operations = new ArrayList<>();
+        private ResponseData data;
 
         @JsonProperty("actionStatus")
         public Builder actionStatus(ActionInvocationResponse.Status actionStatus) {
@@ -75,6 +83,14 @@ public Builder operations(@JsonProperty("operations") List<PerformableOperation>
             return this;
         }
 
+        @JsonDeserialize(using = ResponseData.ResponseDataDeserializer.class)
+        @JsonProperty("data")
+        public Builder context(@JsonProperty("data") ResponseData data) {
+
+            this.data = data;
+            return this;
+        }
+
         public ActionInvocationSuccessResponse build() {
 
             if (this.actionStatus == null) {
@@ -85,10 +101,6 @@ public ActionInvocationSuccessResponse build() {
                 throw new IllegalArgumentException("actionStatus must be SUCCESS.");
             }
 
-            if (this.operations == null) {
-                throw new IllegalArgumentException("operations must not be null.");
-            }
-
             return new ActionInvocationSuccessResponse(this);
         }
     }

components/action-mgt/org.wso2.carbon.identity.action.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/ResponseData.java

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com).
+ *
+ * WSO2 LLC. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.wso2.carbon.identity.action.execution.model;
+
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonDeserializer;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.wso2.carbon.identity.action.execution.impl.ActionInvocationResponseClassFactory;
+
+import java.io.IOException;
+
+/**
+ * This interface defines the ResponseData for action invocation success response.
+ * The ResponseData is the class that is responsible for defining structure of the additional data coming from the
+ * success invocation response received from the action execution.
+ */
+public interface ResponseData {
+
+    /**
+     * Default ResponseData implementation, which can be used when there are no extended ResponseData class for
+     * the action type.
+     */
+    class DefaultResponseData implements ResponseData {
+    }
+
+    /**
+     * Dynamic deserializer for the ResponseData class.
+     */
+    class ResponseDataDeserializer extends JsonDeserializer<ResponseData> {
+
+        public static final String ACTION_TYPE_ATTR_NAME = "actionType";
+
+        @Override
+        public ResponseData deserialize(JsonParser p, DeserializationContext ctxt)
+                throws IOException {
+
+            ActionType actionType = (ActionType) ctxt.getAttribute(ACTION_TYPE_ATTR_NAME);
+            JsonNode node = p.getCodec().readTree(p);
+            ObjectMapper mapper = (ObjectMapper) p.getCodec();
+            return mapper.treeToValue(node,
+                    ActionInvocationResponseClassFactory.getInvocationSuccessResponseContextClass(actionType));
+        }
+    }
+}