Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action execution to have data in the action invocation success response #6320

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Jan 21, 2025

Issue:

With the custom authentication extension, the JSON response body for a successful action invocation will include authenticated user information under data. The data field can represent a class defined by the downstream component. A generic solution is required to deserialize this data payload, with its structure being determined by the downstream component.

@Thisara-Welmilla Thisara-Welmilla marked this pull request as draft January 21, 2025 06:55
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from 03667aa to 8c4d9a4 Compare January 21, 2025 09:14
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch 2 times, most recently from 52df562 to 67ae6b6 Compare January 22, 2025 14:56
@Thisara-Welmilla Thisara-Welmilla changed the title Add AuthenticatorAdapterService to get authentiactor instance for user defined authenticators. Improve action invocation response model Jan 22, 2025
@Thisara-Welmilla Thisara-Welmilla marked this pull request as ready for review January 22, 2025 14:57
@Thisara-Welmilla Thisara-Welmilla changed the title Improve action invocation response model Improve action execution to have data in the action invocation success response Jan 22, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12911096255

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12911096255
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch 3 times, most recently from 32917c1 to ddf9b40 Compare January 23, 2025 02:40
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from ddf9b40 to 71a366f Compare January 23, 2025 02:58
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (5570948) to head (6a309ee).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...tion/internal/ActionExecutionServiceComponent.java 0.00% 6 Missing ⚠️
...ion/impl/ActionInvocationResponseClassFactory.java 90.00% 1 Missing ⚠️
.../DefaultActionInvocationResponseClassProvider.java 75.00% 1 Missing ⚠️
...ity/action/execution/impl/DefaultResponseData.java 0.00% 1 Missing ⚠️
...ecution/model/ActionInvocationSuccessResponse.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6320      +/-   ##
============================================
+ Coverage     46.49%   46.56%   +0.07%     
- Complexity    14740    14755      +15     
============================================
  Files          1701     1706       +5     
  Lines        103349   103383      +34     
  Branches      18558    18558              
============================================
+ Hits          48049    48139      +90     
+ Misses        48444    48383      -61     
- Partials       6856     6861       +5     
Flag Coverage Δ
unit 29.90% <78.26%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from ba0015d to 700c3a1 Compare January 23, 2025 04:41
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from 700c3a1 to b80bbe8 Compare January 23, 2025 04:45
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12924577731

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12924577731
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from bc43399 to 6f14617 Compare January 24, 2025 03:05
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from 6008a93 to a37cbc1 Compare January 24, 2025 03:15
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from a4dba21 to af2d974 Compare January 24, 2025 05:24
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from af2d974 to e00f179 Compare January 24, 2025 05:55
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch 3 times, most recently from 34e3fdb to 6fd2554 Compare January 24, 2025 09:47
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action-invocation-success-response branch from 6fd2554 to 6a309ee Compare January 24, 2025 09:48
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12947652798

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12947652798
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants