coldcard: get the tap_key_sig from the signed tx #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
approved these changes
Jul 16, 2024
edouardparis
added a commit
to wizardsardine/liana
that referenced
this pull request
Jul 18, 2024
546d232 gui: add coldcard support (pythcoiner) Pull request description: This PR add support for taproot w/ coldcard devices We need to wait [async-hwi PR](wizardsardine/async-hwi#92) to be merged berfore merge this one. Tested w/ internal key & taptree on Mk4 ACKs for top commit: edouardparis: ACK 546d232 Tree-SHA512: 4e1bf3782a3533c2f0bb06010397ed2254fbc4420160a4312f7ad58ee85e5225d8543395863cf25efbb3301b9c1e10d6d11f158d3385cdd1cf8d6780edff92a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the tap_key_sig was not copied from the tx returned by the device.