Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coldcard support #1193

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

pythcoiner
Copy link
Collaborator

@pythcoiner pythcoiner commented Jul 11, 2024

This PR add support for taproot w/ coldcard devices
We need to wait async-hwi PR to be merged berfore merge this one.

Tested w/ internal key & taptree on Mk4

@edouardparis
Copy link
Member

Can you rebase and update the crate version of async-hwi to 0.0.22 in this PR ? Thank you

@pythcoiner pythcoiner force-pushed the coldcard_taproot branch 2 times, most recently from 4460cfb to ac413f2 Compare July 18, 2024 01:00
@pythcoiner
Copy link
Collaborator Author

Can you rebase and update the crate version of async-hwi to 0.0.22 in this PR ? Thank you

done

@pythcoiner pythcoiner changed the title [WIP] add coldcard support add coldcard support Jul 18, 2024
Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 546d232

@edouardparis edouardparis merged commit 48d3490 into wizardsardine:master Jul 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants