Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent listening and manipulating the anchor navigations when using a direct link #1274

Merged
merged 1 commit into from
Aug 19, 2024
Merged

prevent listening and manipulating the anchor navigations when using a direct link #1274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/gallery/src/components/item/itemView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,12 @@ class ItemView extends React.Component {
onItemInfoClick(e) {
const clickTarget = 'item-info';
this.onItemClick(e, clickTarget, false);
e.stopPropagation();
if (!this.shouldUseDirectLink()) {
// stop propagation only if we are not using direct link.
// stop propagation will prevent listening and manipulating the anchor navigations as some users do.
// we dont want to do this when we use a direct link via a tag.
e.stopPropagation();
}
}

onItemClick(e, clickTarget, shouldPreventDefault = true) {
Expand Down
Loading