Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent listening and manipulating the anchor navigations when using a direct link #1274

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Galpittel
Copy link
Collaborator

stop propagation only if we are not using direct link.
stop propagation will prevent listening and manipulating the anchor navigations as some users do.
we don't want to do this when we use a direct link via a tag.

Copy link
Contributor

@liatv liatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@Galpittel Galpittel merged commit b5b5d57 into master Aug 19, 2024
5 of 7 checks passed
@Galpittel Galpittel deleted the fix-info-element-on-click-preview-mode branch August 19, 2024 08:32
Galpittel added a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants