Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: feature flag for paginated conversation list [WPB-12070] #3578

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 1, 2024

StoryWPB-12070 [Android] place conversation pagination in a feature flag


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

place pagination changes under a feature flag

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 41.57303% with 52 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (6593a50) to head (f0290ad).

Files with missing lines Patch % Lines
...ome/conversationslist/ConversationListViewModel.kt 41.17% 33 Missing and 17 partials ⚠️
...ui/home/conversationslist/ConversationListState.kt 66.66% 1 Missing ⚠️
...home/conversationslist/model/ConversationFolder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3578      +/-   ##
=====================================================
- Coverage              45.35%   45.29%   -0.07%     
=====================================================
  Files                    470      470              
  Lines                  15717    15798      +81     
  Branches                2627     2656      +29     
=====================================================
+ Hits                    7128     7155      +27     
- Misses                  7839     7875      +36     
- Partials                 750      768      +18     
Files with missing lines Coverage Δ
...ui/home/conversationslist/ConversationListState.kt 66.66% <66.66%> (-33.34%) ⬇️
...home/conversationslist/model/ConversationFolder.kt 42.85% <0.00%> (+42.85%) ⬆️
...ome/conversationslist/ConversationListViewModel.kt 31.44% <41.17%> (-2.56%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6593a50...f0290ad. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Built wire-android-staging-compat-pr-3578.apk is available for download

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 4, 2024
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! Maybe just a ticket number to reference later would be nice to not forget to remove this deprecated version + feature flag

Copy link

sonarcloud bot commented Nov 4, 2024

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Built wire-android-staging-compat-pr-3578.apk is available for download

@MohamadJaara MohamadJaara changed the title refactor: feature flag for paginated conversation list refactor: feature flag for paginated conversation list [WPB-12070] Nov 4, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 4, 2024
Merged via the queue into release/candidate with commit 0df994e Nov 4, 2024
14 of 16 checks passed
@MohamadJaara MohamadJaara deleted the refactor/feature-flag-for-paginated-conversation-list branch November 4, 2024 16:57
@echoes-hq echoes-hq bot added echoes: features End-user visible changes intended to create customer value and removed echoes: features End-user visible changes intended to create customer value labels Nov 5, 2024
@echoes-hq echoes-hq bot added the echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants