-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: feature flag for paginated conversation list [WPB-12070] #3578
refactor: feature flag for paginated conversation list [WPB-12070] #3578
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3578 +/- ##
=====================================================
- Coverage 45.35% 45.29% -0.07%
=====================================================
Files 470 470
Lines 15717 15798 +81
Branches 2627 2656 +29
=====================================================
+ Hits 7128 7155 +27
- Misses 7839 7875 +36
- Partials 750 768 +18
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ated-conversation-list
app/src/test/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModelTest.kt
Show resolved
Hide resolved
app/src/test/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModelTest.kt
Outdated
Show resolved
Hide resolved
Built wire-android-staging-compat-pr-3578.apk is available for download |
…ated-conversation-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ! Maybe just a ticket number to reference later would be nice to not forget to remove this deprecated version + feature flag
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3578.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
place pagination changes under a feature flag
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.