Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: feature flag for paginated conversation list [WPB-12070] 🍒 #3612

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Nov 7, 2024

StoryWPB-12070 [Android] place conversation pagination in a feature flag

This PR was manually cherry-picked based on the following PR:

Original PR description:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

place pagination changes under a feature flag

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.83333% with 52 lines in your changes missing coverage. Please review.

Project coverage is 45.27%. Comparing base (e3c1dee) to head (215b04a).

Files with missing lines Patch % Lines
...ome/conversationslist/ConversationListViewModel.kt 45.55% 31 Missing and 18 partials ⚠️
...ui/home/conversationslist/ConversationListState.kt 60.00% 2 Missing ⚠️
...home/conversationslist/model/ConversationFolder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3612      +/-   ##
===========================================
- Coverage    45.33%   45.27%   -0.07%     
===========================================
  Files          472      472              
  Lines        15794    15879      +85     
  Branches      2632     2662      +30     
===========================================
+ Hits          7160     7189      +29     
- Misses        7884     7922      +38     
- Partials       750      768      +18     
Files with missing lines Coverage Δ
...home/conversationslist/model/ConversationFolder.kt 42.85% <0.00%> (+42.85%) ⬆️
...ui/home/conversationslist/ConversationListState.kt 60.00% <60.00%> (-40.00%) ⬇️
...ome/conversationslist/ConversationListViewModel.kt 33.19% <45.55%> (-2.21%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c1dee...215b04a. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Built wire-android-staging-compat-pr-3612.apk is available for download

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Built wire-android-dev-debug-pr-3612.apk is available for download

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, MohamadJaara and damian-kaczmarek and removed request for a team November 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants