Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: android gradle plugin update [WPB-983] #3519

Merged
merged 2 commits into from
Oct 17, 2024
Merged

chore: android gradle plugin update [WPB-983] #3519

merged 2 commits into from
Oct 17, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 16, 2024 •
edited by github-actions bot
Loading

StoryWPB-983 Snapshot tests for UI changes verification

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated android gradle plugin needed for screenshot tests

@Garzas Garzas self-assigned this Oct 16, 2024
@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3519.apk is available for download

@Garzas Garzas enabled auto-merge October 17, 2024 06:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Garzas Garzas added this pull request to the merge queue Oct 17, 2024
Merged via the queue into release/candidate with commit 2c80996 Oct 17, 2024
12 of 14 checks passed
@Garzas Garzas deleted the chore/agp-8-5 branch October 17, 2024 07:43
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
@Garzas @github-actions
chore: android gradle plugin update [WPB-983] (#3519)
8d0f167
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-kaczmarek damian-kaczmarek damian-kaczmarek approved these changes

@m-zagorski m-zagorski m-zagorski approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@borichellow borichellow Awaiting requested review from borichellow

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@saleniuk saleniuk Awaiting requested review from saleniuk

Assignees

@Garzas Garzas

Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garzas @m-zagorski @damian-kaczmarek