Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: android gradle plugin update [WPB-983] 🍒 #3521

Merged
merged 3 commits into from
Oct 17, 2024
Merged

chore: android gradle plugin update [WPB-983] 🍒 #3521

merged 3 commits into from
Oct 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:

StoryWPB-983 Snapshot tests for UI changes verification

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated android gradle plugin needed for screenshot tests

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS labels Oct 17, 2024
@Garzas Garzas enabled auto-merge October 17, 2024 09:17
@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Garzas Garzas added this pull request to the merge queue Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3521.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor Author

Built wire-android-dev-debug-pr-3521.apk is available for download

Merged via the queue into develop with commit 3e6140b Oct 17, 2024
12 of 13 checks passed
@Garzas Garzas deleted the chore/agp-8-5-cherry-pick branch October 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-kaczmarek damian-kaczmarek damian-kaczmarek approved these changes

@m-zagorski m-zagorski m-zagorski approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@saleniuk saleniuk Awaiting requested review from saleniuk

@borichellow borichellow Awaiting requested review from borichellow

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@Garzas Garzas

Labels
cherry-pick PR is cherry-picking changes from another banch echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-zagorski @damian-kaczmarek @Garzas