Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1:1 calls can not be established on staging environment (WPB-9359) - approach 3 #3037

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 24, 2024

BugWPB-9359 [Android] 1:1 calls can not be established on staging environment

…ta build


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

1:1 calls can not be established.

Causes (Optional)

After extracting calls to another Activity, the app cannot observe its lifecycle state properly.

Solutions

Move observing from WireActivity to WireApplication so that it's in one place and the state is consistent across the app.

Testing

How to Test

STR:

  • Login to staging env on android as user A
  • Login to saging env on web as user B
  • Start a 1:1 call on android as user A
  • Pick it up on web as user B

Expected:

  • 1:1 call should be established

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 24, 2024

Test Results

928 tests   928 ✅  13m 17s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 2fdafbe.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4989 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 4990 failed.

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4991 succeeded.

The build produced the following APK's:

@ohassine ohassine requested review from a team, alexandreferris, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team May 27, 2024 09:05
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MohamadJaara MohamadJaara merged commit f0b42cf into release/candidate May 27, 2024
14 checks passed
@MohamadJaara MohamadJaara deleted the one-on-one-call-could-not-be-established-rc-approach3 branch May 27, 2024 09:09
github-actions bot pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants