-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 1:1 calls can not be established on staging environment (WPB-9359) - approach 3 #3037
fix: 1:1 calls can not be established on staging environment (WPB-9359) - approach 3 #3037
Conversation
…ne-call-could-not-be-established-rc-approach3
Test Results928 tests 928 ✅ 13m 17s ⏱️ Results for commit 2fdafbe. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4989 succeeded. The build produced the following APK's: |
Build 4990 failed. |
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4991 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…9) - approach 3 (#3037) Co-authored-by: Oussama Hassine <[email protected]>
…ta build
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
1:1 calls can not be established.
Causes (Optional)
After extracting calls to another Activity, the app cannot observe its lifecycle state properly.
Solutions
Move observing from
WireActivity
toWireApplication
so that it's in one place and the state is consistent across the app.Testing
How to Test
STR:
Expected:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.