Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1:1 calls can not be established on staging environment (WPB-9359) 🍒 #3038

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 27, 2024

BugWPB-9359 [Android] 1:1 calls can not be established on staging environment

This PR was automatically cherry-picked based on the following PR:

Original PR description:


…ta build


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

1:1 calls can not be established.

Causes (Optional)

After extracting calls to another Activity, the app cannot observe its lifecycle state properly.

Solutions

Move observing from WireActivity to WireApplication so that it's in one place and the state is consistent across the app.

Testing

How to Test

STR:

  • Login to staging env on android as user A
  • Login to saging env on web as user B
  • Start a 1:1 call on android as user A
  • Pick it up on web as user B

Expected:

  • 1:1 call should be established

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 27, 2024
@ohassine ohassine changed the title fix: 1:1 calls can not be established on staging environment (WPB-9359) - approach 3 🍒 fix: 1:1 calls can not be established on staging environment (WPB-9359) 🍒 May 27, 2024
@AndroidBob
Copy link
Collaborator

Build 4995 succeeded.

The build produced the following APK's:

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MohamadJaara MohamadJaara added this pull request to the merge queue May 27, 2024
Copy link
Contributor Author

Test Results

931 tests  ±0   931 ✅ ±0   9m 13s ⏱️ - 3m 45s
124 suites ±0     0 💤 ±0 
124 files   ±0     0 ❌ ±0 

Results for commit 1677cc9. ± Comparison against base commit 7f02ec4.

Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 1522528 May 27, 2024
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the one-on-one-call-could-not-be-established-rc-approach3-cherry-pick branch May 27, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants